fix: /review-translations filter API field#18275
Merged
Merged
Conversation
The ETHGlossary POST /api/v1/filter endpoint expects a `content` field, but the slash command sent `text`. The API silently returned a Zod validation error, so agent-run reviews fell back to memory-based heuristics instead of querying the glossary. This was a contributing factor to the false-positive criticals on PR 18273 (acronym transliterations that exactly matched glossary entries were flagged as needing reversion to Latin). Verified against ethglossary.visual-20-hoists.workers.dev with a minimal payload. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
May 26, 2026
This was referenced May 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ETHGlossary
POST /api/v1/filterendpoint expects acontentfield, but.claude/commands/review-translations.mdsenttext. The API returns a Zod validation error, so agent-run reviews silently fall back to memory-based heuristics instead of querying the glossary.This was a contributing factor to the false-positive criticals on PR #18273, where acronym transliterations that exactly matched ETHGlossary entries were flagged as needing reversion to Latin.
Test plan
ethglossary.visual-20-hoists.workers.dev/api/v1/filterintl-knowledge-baseis patched separately)