Skip to content

fix(weekly-release): grant id-token permission and require RELEASE_BOT_TOKEN #18257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettinarip merged 2 commits into from
May 22, 2026
Merged

fix(weekly-release): grant id-token permission and require RELEASE_BOT_TOKEN #18257

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c4da4b
fix(weekly-release): grant id-token: write for claude-code-action OIDC
pettinarip May 22, 2026
78e5aca
fix(weekly-release): drop GITHUB_TOKEN fallback for RELEASE_BOT_TOKEN
pettinarip May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/weekly-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
permissions:
contents: write
pull-requests: write
id-token: write
Copy link
Copy Markdown
Member

@wackerow wackerow May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


concurrency:
group: weekly-release
Expand All @@ -19,9 +20,9 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
env:
# Use a bot token so the auto-created deploy PR triggers downstream
# pull_request workflows (GITHUB_TOKEN-authored PRs don't).
GH_TOKEN: ${{ secrets.RELEASE_BOT_TOKEN || secrets.GITHUB_TOKEN }}
# Required: deploy PR must be authored by a bot token so downstream
# pull_request workflows fire.
GH_TOKEN: ${{ secrets.RELEASE_BOT_TOKEN }}
Copy link
Copy Markdown
Member

@wackerow wackerow May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I see this loaded now, thanks

outputs:
skipped: ${{ steps.skip_check.outputs.skip }}
skip_reason: ${{ steps.skip_check.outputs.reason }}
Expand All @@ -34,7 +35,7 @@ jobs:
uses: actions/checkout@v6
with:
fetch-depth: 0
token: ${{ secrets.RELEASE_BOT_TOKEN || secrets.GITHUB_TOKEN }}
token: ${{ secrets.RELEASE_BOT_TOKEN }}

- name: Configure git identity
run: |
Expand Down
Loading