fix(weekly-release): grant id-token permission and require RELEASE_BOT_TOKEN#18257
Merged
Conversation
The action authenticates with Anthropic via GitHub OIDC and fails with "Could not fetch an OIDC token" without this permission. First test run on dev (workflow run 26290559253) failed for this reason.
Falling back to GITHUB_TOKEN looks safe but silently degrades: the deploy PR is created, but no pull_request workflows fire on it (CI, deploy preview), and the Discord notification still reports success. Fail fast instead if RELEASE_BOT_TOKEN is missing.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
May 22, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Looks good @pettinarip, sorry for the premature merge on #18220 but I think this should do it
| GH_TOKEN: ${{ secrets.RELEASE_BOT_TOKEN || secrets.GITHUB_TOKEN }} | ||
| # Required: deploy PR must be authored by a bot token so downstream | ||
| # pull_request workflows fire. | ||
| GH_TOKEN: ${{ secrets.RELEASE_BOT_TOKEN }} |
Member
There was a problem hiding this comment.
Nice, I see this loaded now, thanks
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| id-token: write |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to
weekly-release.ymlafter the first manual test run ondev(run 26290559253) failed:id-token: writeat the workflow level.anthropics/claude-code-action@v1authenticates with Anthropic via GitHub OIDC and the failed run loggedCould not fetch an OIDC token. Did you remember to add 'id-token: write' to your workflow permissions?secrets.GITHUB_TOKENfallback forRELEASE_BOT_TOKEN. The fallback looked safe but silently degraded: withGITHUB_TOKENauthoring the deploy PR, nopull_requestworkflows would fire on it (CI, Netlify preview), while Discord still reported success. Better to fail loudly if the bot token isn't set.Test plan
RELEASE_BOT_TOKENis set in repo secrets (currently a PAT scoped toethereum/ethereum-org-websitewith Contents, PRs, Workflows R/W).weekly-release.ymlviaworkflow_dispatchand confirm theRun /prepare-releasestep no longer fails on OIDC.RELEASE_BOT_TOKENis unset, confirm the workflow fails fast at the checkout /ghstep instead of silently degrading.