fix(e2e): align tests with SSR wallet list and renamed nav subsection#18108
Merged
Conversation
- FindWalletPage walletRows: exclude hidden rows so filter assertions only run against visible wallets after the find-wallet list switched from virtualization to render-all-and-hide. - home mobile nav: subsection renamed from "basics" to "ethereum explained" in the navigation update.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated regressions in the v11.6.0 release broke
Tests / e2e-tests(failed run). Both are test-side fixes; no product behavior changes.FindWalletPage.walletRows— fix(seo): ssr the wallet list on /wallets/find-wallet #18067 changed the find-wallet list from a virtualizer to render-all-and-hide for SSR. Filtered-out wallets are still in the DOM withclass="hidden", soverifyFilteredResultswas iterating over hidden rows that legitimately don't contain the chosen OS keyword. Narrowed the locator to:scope > details:not(.hidden).home.spec.tsmobile nav — Navigation update - remove use case pop-out #18058 renamed thelearn/basicssubsection tolearn/ethereum-explained(label"Ethereum explained"). The literal"basics"no longer matches any button in the mobile sidebar. Updated to"ethereum explained".Test plan
find-wallet sidebar filters - desktop(e2e) passes locallyfind-wallet sidebar filters - mobile(e2e-mobile-chrome) passes locallyhome navigation menu - mobile(e2e-mobile-chrome) passes locallyTests / e2e-testsworkflow goes green on this PR