Deploy v11.6.1#18150
Merged
Merged
Conversation
Integrated review findings: - Merged Unit 3 (scripts) into Unit 1 — not independently deliverable - Clarified two-job CI rationale: enables partial archive upload on failure - Resolved getGFIs() open question — fetch-gfis.json covers it via USE_MOCK_DATA - Documented reuseExistingServer caveat for local dev determinism - Clarified catch-all page coverage in Unit 2
Use --frozen-lockfile on both pnpm installs so CI cannot silently drift from the committed lockfile. Also drop the unneeded `if: always()` on chromatic-upload; it was only ever reachable via `needs`, so the default already gates it on the build job producing artifacts to upload.
networkidle is flaky on Next.js pages due to analytics beacons and prefetch — the explicit stable-selector + nav-skeleton-detach waits already gate readiness, so domcontentloaded is enough. Also default stableSelector to "h1" in the loop destructure and drop the 15 redundant literals from the page table.
…tic-page-visual-tests
The previous merge of origin/dev preferred dev's lockfile, which dropped @chromatic-com/playwright added by this branch. Regenerated to restore the missing entry and unblock unit-tests CI.
The webServer block ran pnpm start for every project, breaking unit tests in CI which don't need (or have) a production build. Gate it on chromatic project args so unit and e2e runs skip it.
Plans under docs/plans/ are local working artifacts and should not be committed alongside feature work.
…tic-page-visual-tests
- Add `isPartOf` to all articles, pointing to WebPage graph node - refactor `url: url,` to `url,` throughout - refactor `articleId` to const on all Article graph nodes Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
…tic-page-visual-tests # Conflicts: # app/[locale]/_components/HomepageLazy.tsx # pnpm-lock.yaml
Apply 13 critical fixes from translation review of PR #18113: - WETH ticker uppercase in id/it/pt-br/sw/te page-get-eth.json - Stray English "by" in sw page-what-is-ethereum.json:35 - Stray English "The" in vi page-what-is-ethereum.json:103 - Restore Frontier brand name in sw and vi page-what-is-ethereum - Restore The Merge brand name in sw page-what-is-ethereum - Lowercase Blokzincir mid-sentence in tr page-what-is-ethereum (x2) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
"non-fungible tokens" was rendered as "fungus-less tokens" (பூஞ்சையற்ற, from பூஞ்சை = fungus). Replace with the ETHGlossary-canonical Tamil term: பதிலீடு செய்ய முடியாத டோக்கன்கள் (literally "irreplaceable tokens"). Source: ethglossary /api/v1/translations/ta/non-fungible%20token%20(nft) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
…e-visual-tests test(visual): add Playwright + Chromatic page visual regression suite
i18n: translation pipeline (all languages)
Updated link to go-eth-kzg
fix(staking): remove excessive whitespace in SaaS product cards
Update chains data - May 1
fix: wallet logo span, title alignment
patch(ui): listing methodology font style
seo: patch layer-2 description and find-wallet heading levels
patch(ui): ExpandableCard adjustments
# Conflicts: # app/[locale]/page-jsonld.tsx
seo(jsonld): bidirectional webPageId and articleId
…on-registry fix(seo): resolve translation status by content, not namespace prefix
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
config ⚙️
pettinarip
commented
May 8, 2026
Member
Author
pettinarip
left a comment
pettinarip
left a comment
There was a problem hiding this comment.
Reviewed against the deploy-preview at https://deploy-preview-18150.ethereum.it/ (staging.ethereum.org was serving a stale build at review time, so checks were performed against the deploy-preview which reflects the exact bits this PR will promote).
| Page | Status | Notes |
|---|---|---|
/ |
✅ | "Daily trading volume (USD)" label present (#18090) |
/layer-2/ |
✅ | Fusaka/PeerDAS Dec 2025 copy live (#18096) |
/layer-2/networks/ |
✅ | JSON-LD @type: CollectionPage + ItemList (#18102) |
/what-is-ethereum/ |
✅ | 2026 roadmap copy (#18088); bidirectional mainEntity ↔ isPartOf JSON-LD (#18034) |
/wallets/find-wallet/ |
✅ | Updated meta title/description (#18101); wallet logo/title alignment OK (#18138) |
/get-eth/ |
✅ | Updated meta (#18100); "Carbon DeFi" display name (#18089) |
/staking/saas/ |
✅ | SaaS card tag whitespace fix (#18081) |
/staking/ |
✅ | ExpandableCard adjustments render correctly (#18091) |
/community/grants/ |
✅ | Etherscan Grant Directory entry present (#18105) |
/es/ |
✅ | Spanish content renders; translation-status fix (#18143) doesn't break locale rendering |
No regressions found. LGTM 🚀
(Self-approval blocked by GitHub — needs another reviewer to formally approve.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡️ Changes
🌐 Translations
📝 Documentation
🔧 Tooling
📦 Dependencies
🦄 Contributors
Thank you @fredrik0x, @konopkja, @nloureiro, @pettinarip and @wackerow for the contributions! 🏆