ci(data-layer): pass TRIGGER_PROJECT_REF to trigger deploy#18107
Merged
Conversation
trigger.config.ts reads process.env.TRIGGER_PROJECT_REF, but the workflow only forwarded TRIGGER_ACCESS_TOKEN, so deploys failed with "Project not found: undefined" on every run since the workflow was added.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Deploy Data Layerjob has failed on every run since it was added (Apr 13, Apr 17, Apr 24 — including the most recent weekly release in #18104) with:trigger.config.ts:9reads the project ref fromprocess.env.TRIGGER_PROJECT_REF, but the workflow only forwardedTRIGGER_ACCESS_TOKEN. The CLI sawundefinedand bailed.This wires
TRIGGER_PROJECT_REF(already configured as a GitHub Actions secret) into the deploy step's env, mirroring howTRIGGER_ACCESS_TOKENis passed.Test plan
TRIGGER_PROJECT_REFsecret is set at the repo / org level so it's available to this workflow.master, watch the next push that touchessrc/data-layer/**,trigger.config.ts, orpackage.jsonand verify theDeploy Data Layerjob goes green.