Skip to content

content(homepage): add USD currency label to trading volume stat#18090

Merged
wackerow merged 3 commits into
ethereum:devfrom
nloureiro:fix/homepage-trading-volume-currency
May 1, 2026
Merged

content(homepage): add USD currency label to trading volume stat#18090
wackerow merged 3 commits into
ethereum:devfrom
nloureiro:fix/homepage-trading-volume-currency

Conversation

@nloureiro
Copy link
Copy Markdown
Contributor

Closes #18085

What this PR does

Adds a (USD) qualifier to the "Daily trading volume" stat label on the homepage feature card to remove ambiguity about the currency.

Changes

  • "Daily trading volume""Daily trading volume (USD)"

Files changed

  • src/intl/en/page-index.json

Why

Spotted during automated weekly QA review on 2026-04-27. The 4.6B+ figure has no unit, making it ambiguous to international users.

The homepage feature card shows '4.6B+ Daily trading volume' with no
currency unit. Without context this is ambiguous — could be any currency.
Add '(USD)' to the label for clarity.

Spotted via: weekly QA review (2026-04-27)
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 40761b7
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69f4d5c6e3ff4000081d331c
😎 Deploy Preview https://deploy-preview-18090.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 69 (🟢 up 4 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Apr 30, 2026
@wackerow
Copy link
Copy Markdown
Member

wackerow commented May 1, 2026

Looks good.. only note, the number above this is indeed a currency, but not being formatted as such. I think this change would best be paired with use of formatSmallUSD which has the same significant digits, but formats as a currency: "USD". Can add a commit with this.

Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
@wackerow
Copy link
Copy Markdown
Member

wackerow commented May 1, 2026

Post merge translation trigger:

gh workflow run "Intl Pipeline" -f target_path=src/intl/en/page-index.json

@wackerow wackerow merged commit a3de998 into ethereum:dev May 1, 2026
10 checks passed
@pettinarip pettinarip mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

content(homepage): trading volume stat missing currency unit (USD)

3 participants