fix(i18n): translate subcategory tags on /apps/ category pages#17891
Merged
Conversation
Translate subcategory tags in the category page before passing to AppsTable and AppsHighlight, matching the pattern used by CategoryAppsGrid. Add translation keys for all non-gaming subcategories (DeFi, Bridge, Social, etc). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
- hi: validator mistranslated as client - fr, pt-br: IP acronym expanded unnecessarily - sw: verbose oracle description -> loanword - zh-tw: governance term aligned with crypto standard Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
i18n: Gemini translations (all languages)
wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
Apply the same subcategory translation pattern from /apps/categories/[category] to the main /apps/ page. Covers Highlights, Discover, TopApps, and CommunityPicks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
# Conflicts: # app/[locale]/apps/categories/[catetgoryName]/page.tsx # app/[locale]/apps/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/apps/categories/*pages were raw English inAppsTableandAppsHighlightwhileCategoryAppsGridalready translated themCategoryAppsGridpatternapp-subcategories.jsonfor all non-gaming categoriesTest plan
Todo
app-subcategories.jsonkeysGenerated by Claude (Opus 4.6)