test(i18n): add unit tests for sanitizer#17654
Merged
Merged
Conversation
Documents 11 new translation artifact patterns found across 10+ PRs (zh-tw, sw, ta, bn, ur, de, ja, zh, es, tr) to inform future sanitizer improvements and test coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Adds _testOnly export to expose internal functions for testing (zero runtime impact). Four test files cover standalone fixes, English-comparison fixes, warning functions, and integration through processMarkdownFile/processJsonFile. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
Guided workflow for iterating on sanitizer bugs: triage (fix vs warn vs document-only), test-first development, cross-language verification, and conditional build checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
github-actions
Bot
added
documentation 📖
wackerow
added a commit
that referenced
this pull request
Feb 25, 2026
Document full review-translations-local pipeline results: - Quality score 7.2/10 across 28 Czech files - 14 issues fixed (MDX syntax, acronyms, URLs, typos) - Key decisions: DNZ->ZKP rationale, glossary deviation deferral - Sanitizer crash on orphaned Crowdin paths documented - Content staleness in 3 roadmap files flagged for retranslation - Prevention strategies and suggested test cases for PR #17654 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_testOnlyexport to sanitizer for unit test access (zero runtime impact)/fix-sanitizer-bugcommand for guided test-first sanitizer iterationTest files
standalone-fixes.spec.tsenglish-comparison.spec.tswarnings.spec.tsintegration.spec.tsTest plan
npx playwright test --project=unit tests/unit/sanitizer/-- 99 passednpx playwright test --project=unit-- all unit tests pass (including existing getters)Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Co-Authored-By: wackerow 54227730+wackerow@users.noreply.github.com