fix(e2e): fix mobile browser e2e test failures and race conditions#16897
Merged
fix(e2e): fix mobile browser e2e test failures and race conditions#16897
Conversation
pettinarip
requested review from
corwintines,
minimalsm and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
reviewed
Dec 15, 2025
| await expect(walletModal.getByText("Connect a Wallet")).toBeVisible() | ||
| await expect(walletModal.getByText("MetaMask")).toBeVisible() | ||
| await expect(walletModal.getByText("Coinbase Wallet")).toBeVisible() | ||
| await expect(walletModal.getByText("Coinbase")).toBeVisible() |
Member
There was a problem hiding this comment.
@pettinarip Hm, what am I missing? Looks like the wallet is named "Coinbase Wallet" in our wallet data
Also, looks like we should probably update that separately: https://www.coinbase.com/wallet ("Coinbase Wallet is now Base app")
Member
Author
There was a problem hiding this comment.
@wackerow this is for the /start page. The test is matching a few wallet names that appear in the connect modal.
wackerow
approved these changes
Dec 15, 2025
This was referenced Dec 18, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky e2e tests that were failing on mobile browsers.
Description
aria-labelanddata-testidto mobile menu dialog for reliable test selectorstoHaveTextassertion instead oftextContent()to avoid timing issues