Fix hreflang tags to only include translated locales#16790
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
97a94c8 to
367df59
Compare
58615d0 to
904a760
Compare
0a6b18e to
79e067e
Compare
corwintines
previously approved these changes
Dec 8, 2025
Member
Author
|
Detected a bug. We are missing the following pages from the sitemap:
These pages don’t use a namespace for translations, so they aren’t listed in the translation registry. We’ll need a different approach to discover intl pages. Instead of pulling them from the registry, I’ll switch to detecting them by scanning the filesystem. |
wackerow
approved these changes
Dec 10, 2025
This was referenced Dec 18, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Built on top of #16804
Description
Fixes hreflang tags to only include translated locales.
High-level changes
index, followmetatag for untranslated pagesImplementation details
Hreflang fix in
getMetadata()Refactor
src/lib/utils/translations.tsUnified translation registry (
src/lib/i18n/translationRegistry.ts)getTranslatedLocales()to check translation status for both MD and intl pagesSitemap refactor (
app/sitemap.ts)next-sitemapplugin to use a the builtinsitemap.tsfilegetAllPagesWithTranslations()from translation registry