Find wallets optimizations#16233
Merged
Merged
Conversation
…resetFilters scope
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
requested changes
Sep 12, 2025
Member
wackerow
left a comment
There was a problem hiding this comment.
Couple tiny patch suggestions, otherwise this looks great! Solid work @pettinarip!
Member
|
@pettinarip Not sure if this would be an appropriate place to address it, but issue #14446 notes a bug where an "opened" wallet accordion acts funny when a user persona is selected once an accordion has been opened, where the accordion in the same position stays open even if it switches to another wallet. PR #14466 is open attempting to address... perhaps you could take a look to see if that would help and could be used here, or if we should close and take another approach. 🙏 Thanks! |
wackerow
approved these changes
Sep 15, 2025
This was referenced Sep 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the Find Wallets page to improve render performance and interaction responsiveness. It replaces the data table layout with a virtualized, accessible list; eliminates duplicated state that caused double renders; and reduces unnecessary component updates across filters and wallet rows.
Key changes
@tanstack/react-virtual.filtersnow single source of truth;presetFiltersderived locally; unified update path; memoized Filter rows; removed hidden desktop duplication.WalletInfoper device; reducedChainImageslayout shift; extractedPersonaTags.Preview link
https://deploy-preview-16233--ethereumorg.netlify.app/wallets/find-wallet