Skip to content

Find Wallet bug: accordion index stays open when switching filters#14466

Closed
dbarabashh wants to merge 6 commits into
ethereum:devfrom
dbarabashh:fix/preserve-wallet-expanded-state
Closed

Find Wallet bug: accordion index stays open when switching filters#14466
dbarabashh wants to merge 6 commits into
ethereum:devfrom
dbarabashh:fix/preserve-wallet-expanded-state

Conversation

@dbarabashh
Copy link
Copy Markdown
Contributor

@dbarabashh dbarabashh commented Dec 6, 2024

fix: preserve wallet expanded state when applying filters in DataTable

Description

This PR fixes the wallet expansion state behavior in the DataTable component when filters are applied. Previously, the expanded state was not properly preserved when filters changed the visible data.

Now:

  • When a wallet is filtered out and then back in, its previous expanded state is preserved
  • Added proper TypeScript types for the expanded state handling

Related Issue

Bug fix for wallet expansion state behavior #14446

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 6, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e439a13
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/675386942c3bd80008af68b4
😎 Deploy Preview https://deploy-preview-14466--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented Dec 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 602d37b src/data/community-events.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions
Copy link
Copy Markdown
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 30, 2025
@wackerow wackerow removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 12, 2025
@wackerow
Copy link
Copy Markdown
Member

Hey @dbarabashh, apologies for delays on this. Been a lot going on.. this page was recently refactored to improve it's performance... @pettinarip has put up a simplified fix for this in #16285, so going to close this out in lieu of that one. Thanks again for diving in!

@wackerow wackerow closed this Sep 16, 2025
@github-actions github-actions Bot added the abandoned This has been abandoned or will not be implemented label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned This has been abandoned or will not be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants