[hot-fix]: LanguagePicker menu button#15737
Merged
Merged
Conversation
differentiate sync vs lazy loaded buttons in Nav/Client/index.tsx. Sync load Button as usual for LanguagePicker; `dynamic` load a separate instance to lazy load theme switcher separately.
wackerow
requested review from
corwintines,
minimalsm and
pettinarip
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
approved these changes
Jun 27, 2025
corwintines
approved these changes
Jun 27, 2025
This was referenced Jul 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Buttonas usual for LanguagePicker to properly forwardrefdynamicload a separate instance (LazyButton) to lazy load theme switcher separatelyRelated Issue