Skip to content

fix: use direct import for Button in LanguagePicker to support ref#15736

Closed
JoeChenJ wants to merge 1 commit into
ethereum:devfrom
JoeChenJ:fix_languagePicker
Closed

fix: use direct import for Button in LanguagePicker to support ref#15736
JoeChenJ wants to merge 1 commit into
ethereum:devfrom
JoeChenJ:fix_languagePicker

Conversation

@JoeChenJ
Copy link
Copy Markdown
Contributor

Description

The LanguagePicker could not open due to a ref error caused by a lazy loaded Button component.

To fix this, the Button is now:

  • Lazy loaded only for the ThemeSwitcher.
  • Directly imported for the LanguagePicker.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 27, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9472749
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/685ee4e10c241200083e4de2
😎 Deploy Preview https://deploy-preview-15736--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🟢 up 5 from production)
Accessibility: 96 (🟢 up 1 from production)
Best Practices: 91 (🟢 up 1 from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@wackerow
Copy link
Copy Markdown
Member

Ah, thanks @JoeChenJ! Great minds think alike! This has already been merged from #15737, going to close this out. Appreciate that quick response though! ❤️

@wackerow wackerow closed this Jun 27, 2025
@github-actions github-actions Bot added the abandoned This has been abandoned or will not be implemented label Jun 27, 2025
@JoeChenJ JoeChenJ deleted the fix_languagePicker branch June 28, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned This has been abandoned or will not be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants