Skip to content

feat: Enhance Language Picker UX for improved discoverability and clarity#15511

Merged
wackerow merged 10 commits into
ethereum:devfrom
Anish-Gupta1:Anish_Gupta1/feat#15488
Jul 16, 2025
Merged

feat: Enhance Language Picker UX for improved discoverability and clarity#15511
wackerow merged 10 commits into
ethereum:devfrom
Anish-Gupta1:Anish_Gupta1/feat#15488

Conversation

@Anish-Gupta1
Copy link
Copy Markdown
Contributor

Description

This PR optimizes the language picker for better user experience, as detailed in the Figma proposal.

Key Changes:

Removed "Browser" tag from UI (functionality retained).
Alphabetical language sorting for easier discovery.
Added localized messages to promote translation efforts based on browser language.

Related Issue

Closes: #15488

@netlify
Copy link
Copy Markdown

netlify Bot commented May 27, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8b78c62
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68758c0721456200080ff026
😎 Deploy Preview https://deploy-preview-15511--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 52 (🟢 up 4 from production)
Accessibility: 94 (no change from production)
Best Practices: 92 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@konopkja
Copy link
Copy Markdown
Contributor

Screenshot 2025-06-12 at 16 34 14

Hi @Anish-Gupta1 , overall it looks good except for the button size here.Could you make the height smaller?

@konopkja
Copy link
Copy Markdown
Contributor

Screenshot 2025-06-12 at 16 35 00

like this

@wackerow
Copy link
Copy Markdown
Member

wackerow commented Jul 9, 2025

Hey @konopkja, I patched the button, but I guess I'm unclear on the logic you're desiring here.

You mentioned having this based on browser locale?

Is your desire that IF a user has a non-english browser locale, we show "Translate to " all in English? Else... not show this footer?

@konopkja
Copy link
Copy Markdown
Contributor

konopkja commented Jul 9, 2025

Hey @konopkja, I patched the button, but I guess I'm unclear on the logic you're desiring here.

You mentioned having this based on browser locale?

Is your desire that IF a user has a non-english browser locale, we show "Translate to " all in English? Else... not show this footer?

  • we show the banner always (for english locales it will just say "translate ethereum.org")
  • if we detect different locale we show variable message for that language (eg - "Translate to Czech")
  • in other languages the prompt should be translated eventually

@wackerow
Copy link
Copy Markdown
Member

wackerow commented Jul 9, 2025

on it

@github-actions github-actions Bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jul 9, 2025
@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jul 10, 2025
@wackerow
Copy link
Copy Markdown
Member

@konopkja https://deploy-preview-15511--ethereumorg.netlify.app/ Let me know if this looks like what you're expecting.

@wackerow wackerow added the needs design approval 🧑‍🎨 Approval from a designer is needed before merging label Jul 11, 2025
@konopkja
Copy link
Copy Markdown
Contributor

@wackerow visually it looks like as expected but i think we are missing some functionality from it now:

  1. order should be alphabetical instead of % translated
  2. browser defaults should still be first

Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made them alphabetical.. cc: @konopkja pulling in; please ping if anything looks off and we can patch

@wackerow wackerow merged commit 9ac7ac5 into ethereum:dev Jul 16, 2025
7 checks passed
@wackerow
Copy link
Copy Markdown
Member

@all-contributors please add @Anish-Gupta1 for code

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @Anish-Gupta1! 🎉

@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Jul 22, 2025
This was referenced Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits needs design approval 🧑‍🎨 Approval from a designer is needed before merging translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: redesign language picker

4 participants