Skip to content

fix(a11y): add title tags to SVG components in run-a-node page #14923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wackerow merged 6 commits into from
Oct 6, 2025
Merged

fix(a11y): add title tags to SVG components in run-a-node page #14923

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f17d46
fix(a11y): add title tags to SVG components in run-a-node page
VolodymyrBg Feb 17, 2025
570aac7
Merge branch 'dev' into pr/VolodymyrBg/14923
wackerow Oct 6, 2025
241f087
fix(a11y): add title tags to SVG components in run-a-node page
wackerow Oct 6, 2025
91ed62a
fix: auto-fill grid sizing
wackerow Oct 6, 2025
96eb4a6
fix(a11y): aria-hidden true for decorative SVG elements
wackerow Oct 6, 2025
da9cc59
chore: use implied "true" boolean value
wackerow Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 15 additions & 25 deletions app/[locale]/run-a-node/_components/run-a-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import InlineLink from "@/components/ui/Link"
import { cn } from "@/lib/utils/cn"

import { useTranslation } from "@/hooks/useTranslation"
import { InfoGrid } from "@/layouts"
import community from "@/public/images/enterprise-eth.png"
import hackathon from "@/public/images/hackathon_transparent.png"
import impact from "@/public/images/impact_transparent.png"
Expand Down Expand Up @@ -367,16 +366,17 @@ const RunANodePage = ({
<H2>
<Translation id="page-run-a-node:page-run-a-node-why-title" />
</H2>
<InfoGrid>
{whyRunANodeCards.map(({ Svg, title, preview, body, alt }) => (
<div className="grid grid-cols-[repeat(auto-fill,_minmax(350px,_1fr))] gap-8">
{whyRunANodeCards.map(({ Svg, title, preview, body }) => (
<ExpandableCard
contentPreview={preview}
title={title}
// TODO: make a11y svgs (using <title>)
// @ts-expect-error alt does not exist as a valid prop
alt={alt}
svg={({ className }) => (
<Svg className={cn("size-16", className)} />
<Svg
className={cn("size-16", className)}
aria-hidden
focusable="false"
/>
)}
key={title}
>
Expand All @@ -385,7 +385,7 @@ const RunANodePage = ({
))}
</ExpandableCard>
))}
</InfoGrid>
</div>
</Content>

<Divider />
Expand All @@ -411,21 +411,13 @@ const RunANodePage = ({
</InlineLink>
</ColumnFill>
<ColumnNarrow>
<Terminal
// TODO: make a11y svgs (using <title>)
// @ts-expect-error alt does not exist as a valid prop
alt={t("page-run-a-node-glyph-alt-terminal")}
/>
<Terminal aria-hidden focusable="false" />
</ColumnNarrow>
</SoftwareHighlight>

<SoftwareHighlight className="flex-col bg-[#FFE3D3] dark:bg-[#332821]">
<ColumnNarrow>
<Dappnode
// TODO: make a11y svgs (using <title>)
// @ts-expect-error alt does not exist as a valid prop
alt={t("page-run-a-node-glyph-alt-dappnode")}
/>
<Dappnode aria-hidden focusable="false" />
</ColumnNarrow>
<ColumnFill>
<Text>
Expand All @@ -444,11 +436,7 @@ const RunANodePage = ({
</Text>
</ColumnFill>
<ColumnNarrow>
<Dapptap
// TODO: make a11y svgs (using <title>)
// @ts-expect-error alt does not exist as a valid prop
alt={t("page-run-a-node-glyph-alt-phone")}
/>
<Dapptap aria-hidden focusable="false" />
</ColumnNarrow>
</SoftwareHighlight>
</GappedContent>
Expand Down Expand Up @@ -522,7 +510,8 @@ const RunANodePage = ({
<SvgTitle>
<HardwareGlyphIcon
className="size-12"
aria-label={t("page-run-a-node-glyph-alt-hardware")}
aria-hidden
focusable="false"
/>
<H3>{t("page-run-a-node-build-your-own-hardware-title")}</H3>
</SvgTitle>
Expand Down Expand Up @@ -592,8 +581,9 @@ const RunANodePage = ({
<BuildContainer>
<SvgTitle>
<DownloadGlyphIcon
aria-label={t("page-run-a-node-glyph-alt-software")}
className="size-12"
aria-hidden
focusable="false"
/>
<H3>{t("page-run-a-node-build-your-own-software")}</H3>
</SvgTitle>
Expand Down