Skip to content

fix(a11y): add title tags to SVG components in run-a-node page#14923

Merged
wackerow merged 6 commits into
ethereum:devfrom
VolodymyrBg:VolodymyrBg
Oct 6, 2025
Merged

fix(a11y): add title tags to SVG components in run-a-node page#14923
wackerow merged 6 commits into
ethereum:devfrom
VolodymyrBg:VolodymyrBg

Conversation

@VolodymyrBg
Copy link
Copy Markdown
Contributor

Add title tags to SVG components for accessibility

Description

Added <title> tags to SVG components in the run-a-node page to improve accessibility for screen readers. This change makes the page more accessible for users with disabilities by providing proper descriptions for SVG icons.

Changes made:

  • Added title tags to all SVG components:
    • Terminal
    • Dappnode
    • Dapptap
    • HardwareGlyphIcon
    • DownloadGlyphIcon
  • Removed redundant alt props and TODO comments
  • Maintained existing translations for accessibility text
  • Used existing translation keys for SVG descriptions

Related Issue

Addresses TODO comments in src/pages/run-a-node.tsx regarding SVG accessibility:
// TODO: make a11y svgs (using <title>)

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 17, 2025

Deploy Preview for ethereumorg canceled.

Name Link
🔨 Latest commit da9cc59
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68e43411637b89000965a787

@VolodymyrBg
Copy link
Copy Markdown
Contributor Author

@chuyeow @matthieu @shazow @fjl

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2025

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions Bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Apr 4, 2025
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VolodymyrBg, apologies for the delays here. Appreciate your help on this.

Took a closer look, and since this PR we've actually updated the way these SVG elements are imported which affects the ability to pass child elements to the imported .svg components.

That being said, these are also decorative elements, so ultimately we don't really need screen-reader labelling for these. A more appropriate approach here is to simply apply aria-hidden="true" (or simply aria-hidden for short, which implies a default true value), and make sure they aren't focusable.

Pulling this in!


(Small aside, applied a quick fix as well to the grid layout of the ExpandableCard components which appeared to have been broken—while I was in here)

@wackerow wackerow added bug 🐛 Something isn't working and removed Status: Stale This issue is stale because it has been open 30 days with no activity. labels Oct 6, 2025
@wackerow wackerow merged commit f272fe6 into ethereum:dev Oct 6, 2025
3 checks passed
@wackerow
Copy link
Copy Markdown
Member

wackerow commented Oct 6, 2025

@all-contributors please add @VolodymyrBg for bug patch

@allcontributors
Copy link
Copy Markdown
Contributor

@wackerow

I've put up a pull request to add @VolodymyrBg! 🎉

This was referenced Oct 9, 2025
This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants