Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular dep issue with Translation component #13813

Merged
merged 1 commit into from
Sep 6, 2024
+6 −6
Merged

Fix circular dep issue with Translation component #13813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/Translation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ type TranslationProps = {
transform?: HtmrOptions["transform"]
}

// Custom components mapping to be used by `htmr` when parsing the translation
// text
const defaultTransform = {
a: TooltipLink,
}

// Renders the translation string for the given translation key `id`. It
// fallback to English if it doesn't find the given key in the current language
const Translation = ({ id, options, transform = {} }: TranslationProps) => {
Expand All @@ -28,6 +22,12 @@ const Translation = ({ id, options, transform = {} }: TranslationProps) => {
const { t } = useTranslation(requiredNamespaces)
const translatedText = t(id, options)

// Custom components mapping to be used by `htmr` when parsing the translation
// text
const defaultTransform = {
a: TooltipLink,
}

// Use `htmr` to parse html content in the translation text
return htmr(translatedText, {
transform: { ...defaultTransform, ...transform },
Expand Down
Loading