Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular dep issue with Translation component #13813

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

pettinarip
Copy link
Member

Description

Moves htmr transformers inside the function component to avoid circular dep problems.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3a48c35
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66db3a24abe6bf000826f2d8
😎 Deploy Preview https://deploy-preview-13813--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 40 (🔴 down 8 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 88 (🔴 down 4 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip merged commit 065a055 into dev Sep 6, 2024
8 of 10 checks passed
@pettinarip pettinarip deleted the fix-circular-dep-2 branch September 6, 2024 18:26
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant