-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: redesign events page ✨ #13374
Feat: redesign events page ✨ #13374
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @konopkja, please check the preview. Also please let me know if any modifications required |
Wow! looking good, there might be few minor adjustments with the interaction but overall this is shaping up pretty well! Thank you.
|
Thank you! surely, making the required modifications. |
Lgtm, thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @saurabhburade! Thanks for the work here, appreciate this. It's overall looking great! I left a note about concerns for non-English pages with the proposed logic for parsing the display date range.
Let me know if what I mentioned makes sense, but ideally these can be displayed properly according to the users locale, and not be forced to just English.
a small UI change requests after team review:
|
@konopkja I'm assuming this is showing Italian ("August" is "agosto", shortened to "ago") |
It's a locale date-time for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @saurabhburade! Mind clearing the merge conflicts an we'll give this a final review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @saurabhburade, sorry to block again. Noted a couple things:
- Clamping lines leads to unreachable content
- Can use
Intl.DateTimeFormat(locale,options).formatRange(from,to)
to get date range string in a simple, easy to maintain, an intl friendly manner to
is now deprecated; usehref
I kinda see 2 and 3 as blocking, curious your take @konopkja
@saurabhburade Gotcha! In that case I'd consider a css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from the design side!!!
Great work!
@saurabhburade, great work, thank you. |
@nloureiro, thank you. The safari issue is fixed now. |
@wackerow Please do the final review, LGTM for approval. |
Looks great, thank @saurabhburade! Can continue to iterate on some other upgrades here, and the tailwind migration separately |
Description
EventCard
UpcomingEventsList
MeetupList
Preview URL
https://deploy-preview-13374--ethereumorg.netlify.app/en/community/events
Related Issue
Fixes #13367