Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events page redesign #13367

Closed
1 of 2 tasks
konopkja opened this issue Jul 10, 2024 · 14 comments · Fixed by #13374
Closed
1 of 2 tasks

Events page redesign #13367

konopkja opened this issue Jul 10, 2024 · 14 comments · Fixed by #13374
Assignees
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@konopkja
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The events page (https://ethereum.org/en/community/events/) has grown and the current design does not support showing many events at the same time. This hinders usability of the page.

Describe the solution you'd like

The team has proposed following design.

light mode

figma designs
https://www.figma.com/design/BEGvi1RiaiFIK4a7MeCl2A/events-page-redesign?node-id=36-67140&t=P9nvjQJW7xAkHsjK-1

Describe alternatives you've considered

NA

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@konopkja konopkja added feature ✨ This is enhancing something existing or creating something new help wanted Extra attention is needed or someone is needed to help dev required This requires developer resources labels Jul 10, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jul 10, 2024
@konopkja konopkja changed the title redesigned events page redesigned events page: need dev Jul 10, 2024
@saurabhburade
Copy link
Contributor

Hey @konopkja, I'm interested in working on this issue

@konopkja
Copy link
Contributor Author

Hi @saurabhburade, thats exciting! I will assign you the issue then! :) Thank you

@saurabhburade
Copy link
Contributor

@konopkja Thank you for assigning the issue, I wanted to know what's the Editors choice, maybe I can add the first event on the list available.

@wackerow
Copy link
Member

Thanks @saurabhburade!

Many of our events are pulled from an external spreadsheet. The details of the logic can be found inside src/scripts/events/ethereum-events-import.ts... The EthereumEventsImport() function is called inside src/scripts/events-import.ts and results assigned to ethereumEvents... These objects here should have an imageUrl property which we're currently not doing anything with... This is not the case for events added separately to this API import, but I would start there and we can figure out a process to get images for other events separately.

@wackerow wackerow removed the needs triage 📥 This issue needs triaged before being worked on label Jul 10, 2024
@wackerow wackerow changed the title redesigned events page: need dev Events page redesign Jul 10, 2024
@konopkja
Copy link
Contributor Author

@konopkja Thank you for assigning the issue, I wanted to know what's the Editors choice, maybe I can add the first event on the list available.

its an idea for new type of event that should be more promoted, for example devcon or devconnect. You would have to create new metadata field for it i assume.

@konopkja
Copy link
Contributor Author

konopkja commented Jul 10, 2024

@konopkja Thank you for assigning the issue, I wanted to know what's the Editors choice, maybe I can add the first event on the list available.

its an idea for new type of event that should be more promoted, for example devcon or devconnect. You would have to create new metadata field for it i assume.

do not add first event, this should be manual choice

if no event has it, do not show this section and title

@saurabhburade
Copy link
Contributor

So this needs to be figured out, which event to promote at top, or maybe have a separate metadata

@saurabhburade
Copy link
Contributor

I have rough preview ready as of now
Screenshot 2024-07-10 at 11 02 24 PM

@konopkja
Copy link
Contributor Author

So this needs to be figured out, which event to promote at top, or maybe have a separate metadata

ok since items are pulled from other sources as well, for now i think lets ship MVP without editor's choice functionality

@saurabhburade

@saurabhburade
Copy link
Contributor

saurabhburade commented Jul 10, 2024

Sounds great!

One thing to be noticed and need help on is that we cannot load external images directly on nextjs and need to whitelist these domains/hostnames through with images that are coming.
I need help to understand what to do with external image URLs?

@konopkja
Copy link
Contributor Author

Sounds great!

One thing to be noticed and need help on is that we cannot load external images directly on nextjs and need to whitelist these domains/hostnames through with images that are coming. I need help to understand what to do with external image URLs?

@wackerow

@wackerow
Copy link
Member

One thing to be noticed and need help on is that we cannot load external images directly on nextjs and need to whitelist these domains/hostnames through with images that are coming. I need help to understand what to do with external image URLs?

Good point... I'm not sure allowlisting will be a sustainable path forward here. We may want to consider iterating on the GitHub action/workflow that pulls in these events to also download and add the event images directly to our repo so we avoid these issues. cc: @pettinarip, thoughts?

@saurabhburade
Copy link
Contributor

As a workaround, I'm using import { Image } from "@chakra-ui/react"

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources feature ✨ This is enhancing something existing or creating something new help wanted Extra attention is needed or someone is needed to help Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants