Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update glossary term definitions [FIXES #12365] #12533

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

tomasgrusz
Copy link
Contributor

  • update requested term definitions in glossary.json
  • update requested term definitions in glossary-tooltip.json

Description

This PR contains updates to the term definitions in the glossary that were introduced in #10975, which was closed, but requested from @konopkja in #12365 to be implemented again in the new glossary structure.

Terms in question:

ABI, block validation, bootnode, bytecode, committee, consensus client, finality, fork, fork-choice algorithm, fraud proof, Merkle Patricia tree, ommer (uncle) block, proof-of-work, reward, Recursive Length Prefix (RLP), shard / shard chain, terminal total difficulty (TTD)

NOTE: the term committee already contains the requested definition, therefore nothing was changed

Related Issue

Update glossary terms #12365

@github-actions github-actions bot added review needed 👀 translation 🌍 This is related to our Translation Program labels Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit ed985de
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6601d6446983420008262268
😎 Deploy Preview https://deploy-preview-12533--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konopkja
Copy link
Contributor

lgtm, thank you for the contribution! <3 Once dev will review the change (this may take few days), we will merge it to production!

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Just two small patches that I'll bring in, thanks @tomasgrusz!

@wackerow wackerow merged commit 333addb into ethereum:dev Mar 25, 2024
5 of 6 checks passed
Copy link

gitpoap-bot bot commented Mar 25, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@wackerow
Copy link
Member

@all-contributors please add @tomasgrusz for code

Copy link
Contributor

@wackerow

I've put up a pull request to add @tomasgrusz! 🎉

This was referenced Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants