Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glossary terms #12365

Closed
konopkja opened this issue Mar 4, 2024 · 5 comments
Closed

Update glossary terms #12365

konopkja opened this issue Mar 4, 2024 · 5 comments
Assignees
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing medium priority This has a medium priority

Comments

@konopkja
Copy link
Contributor

konopkja commented Mar 4, 2024

Update these terms to our new glossary JSON structure from old PR, ignore others as they have been updated in a different ticket.

ABI
block validation
bootnode
bytecode
committee
consensus client
finality
fork
fork-choice algorithm
fraud proof
Merkle Patricia trie
ommer (uncle) block
proof-of-work
reward
Recursive Length Prefix (RLP)
shard / shard chain
terminal total difficulty (TTD)

from this old PR: #10975

@konopkja konopkja added the dev required This requires developer resources label Mar 4, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Mar 4, 2024
@wackerow wackerow added medium priority This has a medium priority good first issue Good item to try if you're new to contributing and removed needs triage 📥 This issue needs triaged before being worked on labels Mar 19, 2024
@tomasgrusz
Copy link
Contributor

Happy to help with this issue, just need a quick explanation to the requested changes.

@pettinarip pettinarip added good first issue Good item to try if you're new to contributing and removed good first issue Good item to try if you're new to contributing labels Mar 19, 2024
@wackerow
Copy link
Member

Hey @konopkja, could you help clarify what needs to be done here? Just a quick spot check, I see "terminal-total-difficulty-definition" in both glossary.json and glossary-tooltip.json, but they are the same... is the goal here to write new tooltip definitions for these?

@konopkja
Copy link
Contributor Author

konopkja commented Mar 20, 2024

Hey @konopkja, could you help clarify what needs to be done here? Just a quick spot check, I see "terminal-total-difficulty-definition" in both glossary.json and glossary-tooltip.json, but they are the same... is the goal here to write new tooltip definitions for these?

We reviewed and closed old PR #10975 instead of merging it, but some of the edits in that PR were good and this issue lists the terms from the original PR that should be added to production.

In the original PR joseph edited some of the terms. So to my knowledge most of them should be already existing, its just that joseph improved the description.

@tomasgrusz
Copy link
Contributor

I understand now, thanks @konopkja. Happy to work on it then.

@konopkja
Copy link
Contributor Author

konopkja commented Mar 20, 2024

I understand now, thanks @konopkja. Happy to work on it then.

thats great! thank you (díky :). I will assign it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources good first issue Good item to try if you're new to contributing medium priority This has a medium priority
Projects
None yet
Development

No branches or pull requests

4 participants