Ensure bids are for a higher slot than their parent - #5302
Merged
Conversation
potuz
approved these changes
May 27, 2026
jtraglia
approved these changes
May 27, 2026
Member
|
Integrated this into the executable function here: 1b20d85 |
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
May 28, 2026
This was referenced May 29, 2026
4 tasks
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 12, 2026
* Ensure bids are for a higher slot than their parent Adopt gossip rule from v1.7.0-alpha.9: - ethereum/consensus-specs#5302 * Fix redundant check
mergify Bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Jun 15, 2026
Changes implemented Ensure bids are for a higher slot than their parent (ethereum/consensus-specs#5302) Ignore PTC attestations for empty assigned slots (ethereum/consensus-specs#5281) Limit should_build_on_full checks to the previous slot (ethereum/consensus-specs#5309) Apply proposer boost if dependent roots match (ethereum/consensus-specs#5306) Exclude slashed validators from proposing (EIP-8045) (ethereum/consensus-specs#5115) Force the proposer to reorg late payloads (ethereum/consensus-specs#5210) Remove support for old deposit mechanism in Fulu (ethereum/consensus-specs#4704) Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu> Co-Authored-By: dapplion <35266934+dapplion@users.noreply.github.com> Co-Authored-By: Eitan Seri-Levi <eserilev@gmail.com> Co-Authored-By: Michael Sproul <michael@sigmaprime.io> Co-Authored-By: Michael Sproul <michaelsproul@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this check, a bid can pass gossip validation while referencing a parent of the same slot. Let's assume
current_slot = 100,bid.slot = 100, andbid.parent_block_rootreferences a known block at the current slot. The existing gossip validation rules would let this bid pass through, but it cannot be included in a valid block.