New alpha.9 spec gossip rules - #10764
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
If gossip ref tests are passing with it, I think we could merge it already, it's sanity checks, shouldn't break compatibility with alpha.8
2 rules added:
ethereum/consensus-specs#5281
ethereum/consensus-specs#5302
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Low Risk
Targeted gossip validation only for Gloas EPBS messages; stricter filtering should not affect unrelated network paths.
Overview
Implements two Gloas/EPBS alpha.9 gossip checks from the updated consensus specs.
Payload attestation messages: After the referenced beacon block is known, validation now requires
block.slot == data.slot. Unknown block slot is saved for future; a slot mismatch is ignored (not rejected).Execution payload bids: Once the parent beacon block鈥檚 slot is known, the bid鈥檚 slot must be strictly greater than the parent鈥檚 slot; equal or lower slots are rejected.
Unit tests cover the mismatch/reject paths; happy-path mocks stub matching parent/attestation slots.
Reviewed by Cursor Bugbot for commit ac7f6c6. Bugbot is set up for automated code reviews on this repo. Configure here.