Add suggestion to queue sidecars per peer - #5199
Merged
Merged
Conversation
sukunrt
force-pushed
the
sukun/sidecar-queue
branch
from
April 29, 2026 14:44
7533941 to
b4397f0
Compare
sukunrt
marked this pull request as ready for review
April 29, 2026 14:45
jtraglia
approved these changes
Apr 29, 2026
jtraglia
left a comment
jtraglia
left a comment
Member
There was a problem hiding this comment.
Amazing. Looks good to me! Thanks for this.
23 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So queueing sidecar per peer helps avoid a DOS situation where a malicious peer takes up all the queue slots.