sync: cap pending Gloas column sidecars per peer - #16777
Open
satushh wants to merge 6 commits into
Open
Conversation
satushh
marked this pull request as ready for review
May 14, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What does this PR do? Why is it needed?
Implements ethereum/consensus-specs#5199 (Gloas data column sidecar queueing).
When a Gloas data column sidecar arrives over gossip before its beacon block has been seen, it's queued for deferred validation. Today in develop, that queue admits sidecars on first-come-first-served basis and stores only one per (root, index), which means a single peer can occupy every queue slot and a malicious peer's invalid sidecar can hide behind another peer's good one.
Changes
-
maxPendingGloasColumnsPerPeer= 128 (total queued columns per peer).-
maxPendingGloasRootsPerPeer= 2 distinct block roots per peer (could be increased if it is too strict).- Counters tracked on Service (
pendingGloasPeerColumnCounts,pendingGloasPeerRootCounts) and released on flush/prune.Acknowledgements