Skip to content

Further simplify DataColumnSidecarsByRoot request #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Further simplify DataColumnSidecarsByRoot request #4323

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7153f8
Further simplify DataColumnSidecarsByRoot request
g11tech May 16, 2025
ef10e21
apply feedback
g11tech May 20, 2025
6f1e2c7
lint
g11tech May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions specs/fulu/p2p-interface.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
- [Modifications in Fulu](#modifications-in-fulu)
- [Preset](#preset)
- [Configuration](#configuration)
- [Containers](#containers)
- [`DataColumnsByRootIdentifier`](#datacolumnsbyrootidentifier)
- [Helpers](#helpers)
- [`verify_data_column_sidecar`](#verify_data_column_sidecar)
- [`verify_data_column_sidecar_kzg_proofs`](#verify_data_column_sidecar_kzg_proofs)
Expand Down Expand Up @@ -62,16 +60,6 @@ specifications of previous upgrades, and assumes them as pre-requisite.
| `MAX_REQUEST_DATA_COLUMN_SIDECARS` | `MAX_REQUEST_BLOCKS_DENEB * NUMBER_OF_COLUMNS` | Maximum number of data column sidecars in a single request |
| `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` | `2**12` (= 4096 epochs, ~18 days) | The minimum epoch range over which a node must serve data column sidecars |

### Containers

#### `DataColumnsByRootIdentifier`

```python
class DataColumnsByRootIdentifier(Container):
block_root: Root
columns: List[ColumnIndex, NUMBER_OF_COLUMNS]
```

### Helpers

##### `verify_data_column_sidecar`
Expand Down Expand Up @@ -419,7 +407,8 @@ Request Content:

```
(
List[DataColumnsByRootIdentifier, MAX_REQUEST_BLOCKS_DENEB]
blocks: List[Root, MAX_REQUEST_BLOCKS_DENEB],
columns: List[ColumnIndex, NUMBER_OF_COLUMNS]
)
```

Expand All @@ -431,10 +420,10 @@ Response Content:
)
```

Requests data column sidecars by block root and column indices. The response is
a list of `DataColumnSidecar` whose length is less than or equal to
Requests data column sidecars by column indices for each of the root in blocks. The response is
a flattened list of `DataColumnSidecar` whose length is less than or equal to
`requested_columns_count`, where
`requested_columns_count = sum(len(r.columns) for r in request)`. It may be less
`requested_columns_count = request.blocks * request.columns`. It may be less
in the case that the responding peer is missing blocks or sidecars.

Before consuming the next response chunk, the response reader SHOULD verify the
Expand Down
Loading