-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Further simplify DataColumnSidecarsByRoot request #4323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further simplify DataColumnSidecarsByRoot request #4323
Conversation
jtraglia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think this change makes sense.
PS: please run make lint to fix the failing CI check.
|
This PR makes sense to me. Having |
can you quantify these? If it's an optimization, it should be quantitative. |
|
In Lighthouse, we only request a single root in all our byroot request. So this change isn't really useful for us imo. |
|
Hey @g11tech, it appears that this change doesn't have a lot of support. |
|
closing the PR as the current/future usage patterns don't warrant this optimization |
PR - #4284 simplified DataColumnSidecarsByRoot request.
this PR further proposes to even pull out columns from the identifiers because a client generally would request same missing columns for a set of roots and hence don't need to keep repeating the same columns again and again for reach block root.
this further shortens the size of request making p2p traffic lighter and should be an easy update to the api usage in the clients.
it may also help the responders to quickly analyze the columns that they need to respond to the request without iterating the entire request which my offer a small space for optimization as well.