generators/kzg_4844: Add positive G1_POINT_AT_INFINITY test vectors#3513
Merged
hwwhww merged 2 commits intoethereum:devfrom Sep 26, 2023
Merged
generators/kzg_4844: Add positive G1_POINT_AT_INFINITY test vectors#3513hwwhww merged 2 commits intoethereum:devfrom
hwwhww merged 2 commits intoethereum:devfrom
Conversation
3f354fd to
0052e68
Compare
hwwhww
approved these changes
Sep 25, 2023
Contributor
hwwhww
left a comment
There was a problem hiding this comment.
I fixed the minor linter errors.
It's great to add BLOB_ALL_TWOS test cases! 👍
@jtraglia
The kzg test vectors with this PR: kzg.tar.gz
Could you help test it against c-kzg before we merge it? 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a similar vein to #3507, this PR is adding some valid test vectors for valid edge-case blobs whose proof or commitment is the point at infinity.
In particular:
As part of this commit, I also edited the
verify_kzg_proof_case_incorrect_proof_point_at_infinity()test to loop over all valid field elements for the evaluation point (lmk if you want me to split it to another commit).Also, I didn't modify the
verify_blob_kzg_proof_batch()test vectors because the edge-case will be tested automatically by addingBLOB_ALL_TWOStoVALID_BLOBSand the testverify_blob_kzg_proof_batch_case_*()./cc @jtraglia