Add KZGProof at G1_POINT_AT_INFINITY test cases
#3507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
requested changes
Sep 19, 2023
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Good idea for this test case! Just some small nits.
tests/generators/kzg_4844/main.py
Outdated
| commitment = spec.blob_to_kzg_commitment(blob) | ||
| proof = spec.G1_POINT_AT_INFINITY | ||
| assert not spec.verify_blob_kzg_proof(blob, commitment, proof) | ||
| yield 'verify_blob_kzg_proof_case_incorrect_proof_point_at_infinity', { |
Member
There was a problem hiding this comment.
Minor nit. I think we should group this with the other "incorrect" tests. So move this test case below the verify_blob_kzg_proof_case_incorrect_proof test case.
tests/generators/kzg_4844/main.py
Outdated
Comment on lines
530
to
532
| assert not spec.verify_blob_kzg_proof_batch([blob], [commitment], [proof]) | ||
|
|
||
| yield 'verify_blob_kzg_proof_batch_case_incorrect_proof_point_at_infinity', { |
Member
There was a problem hiding this comment.
Like the other one, I think this should be in the "incorrect" group of tests. So below the verify_blob_kzg_proof_batch_case_incorrect_proof_add_one test.
Member
|
Also, I can confirm that these tests pass in c-kzg-4844. |
hwwhww
changed the title
G1_POINT_AT_INFINITY test caseG1_POINT_AT_INFINITY test cases
Contributor
|
Cc @etan-status who mentioned an issue related to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.