Conversation
There were a couple instances where a division was used on an epoch to derive the corresponding sync committee period instead of calling the `compute_sync_committee_period` function. These instances were changed to also use the function.
When a light client updates its `finalized_header` using a forced update because of the timeout, and the new header was not signed by enough sync committee participants to pass `get_safety_threshold(store)`, it may occur that `store.finalized_header.slot > store.optimistic_header.slot`. This patch ensures that the `optimistic_header` is updated to the latest `finalized_header` if that happens, so that it always indicates the latest known and accepted head.
The spec reserves the libp2p error code range `[3, 127]` for future use but actually defines error code `3` as `ResourceUnavailable`. This patch updates the reserved range to `[4, 127]`.
Consistently use `compute_sync_committee_period`
Update reserved libp2p error documentation
Fix typo justified
Ensure light client `optimistic_header` to be at head
Minor refactoring for test_sync_protocol.py
When nodes are syncing but have not yet reached the canonical `head`, they cannot determine whether nodes they are connected to serve a valid history or are making bogus claims in their `Status` advertisement. Thus, the best course of action that a client can take is to vote for its "current" best synced head, regardless of whether it's connected to peers that claim to have other heads or not. However, in the p2p spec, we penalize such peers with a `REJECT` - this should be an `IGNORE` instead because this vote is correct per the spec, albeit "late" according to the validating clients' view of the chain.
Bellatrix: random -> prev_randao
Ignore attestations voting for the wrong finalized checkpoint
bump VERSION.txt to 1.1.10
1 task
revert removal of aggregate deduplication condition from #2183
Refactoring: add `is_finality_update` helper
djrtwo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo: