Ignore attestations voting for the wrong finalized checkpoint - #2830
Merged
Merged
Conversation
When nodes are syncing but have not yet reached the canonical `head`, they cannot determine whether nodes they are connected to serve a valid history or are making bogus claims in their `Status` advertisement. Thus, the best course of action that a client can take is to vote for its "current" best synced head, regardless of whether it's connected to peers that claim to have other heads or not. However, in the p2p spec, we penalize such peers with a `REJECT` - this should be an `IGNORE` instead because this vote is correct per the spec, albeit "late" according to the validating clients' view of the chain.
djrtwo
approved these changes
Feb 25, 2022
djrtwo
left a comment
djrtwo
left a comment
Contributor
There was a problem hiding this comment.
as discussed, this could help from network wide deadlocks or network fragmentation in the extreme
bors Bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Mar 4, 2022
## Issue Addressed Addresses spec changes from v1.1.0: - ethereum/consensus-specs#2830 - ethereum/consensus-specs#2846 ## Proposed Changes * Downgrade the REJECT for `HeadBlockFinalized` to an IGNORE. This applies to both unaggregated and aggregated attestations. ## Additional Info I thought about also changing the penalty for `UnknownTargetRoot` but I don't think it's reachable in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When nodes are syncing but have not yet reached the canonical
head,they cannot determine whether nodes they are connected to serve a valid
history or are making bogus claims in their
Statusadvertisement.Thus, the best course of action that a client can take is to vote for
its "current" best synced head, regardless of whether it's connected to
peers that claim to have other heads or not.
However, in the p2p spec, we penalize such peers with a
REJECT- thisshould be an
IGNOREinstead because this vote is correct per the spec,albeit "late" according to the validating clients' view of the chain.