Fix store_target_checkpoint_state #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release v0.12.0
Release v0.12.1
adiasg
force-pushed
the
fix_store_target_checkpoint_state
branch
from
b85afca
to
993ed5c
Compare
…um/eth2.0-specs into fix_store_target_checkpoint_state
djrtwo
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
great! added a couple of tests to hit both scenarios and saw that the same slot state update did fail before the fix
Thanks @ericsson49 and @adiasg
This was referenced Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1883