Release v0.12.1 #1868
Merged
Release v0.12.1 #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ErrorMessage.error_message` is a leftover from an older version of SSZ that was able to encode unbounded lists. This is no longer the case - all collection types now have a fixed upper bound on length. In general, the `error_message`, just like the `graffitti` field, should not be interpreted in any particular way except for debugging and vanity - as such, using the same type, a `Bytes32`, seems reasonable. An alternative would be `List[byte, 256]` which maybe could be "reasonably backwards compatible" with whatever clients are are doing now - depending on how they are dealing with this field type that no longer exists in the SSZ spec :) It would however be the only place where `List[uintN, N]` is used in the current spec. As an exercise, this could be considered a security issue since it's essentially unbounded and undefined behaviour.
broken link to custory-game.md
broken link
Use `compute_previous_slot` for `slot - 1` occurrences
…testation Fix phase1 on-time sign_indexed_attestation
…ransition `compute_shard_transition_digest` expects `Root` as a fourth parameter
Update link so gossipsub encodings match the correct section
Change it to `is_on_time_attestation` so that it could be reused in `validate_attestation`.
Add `shard` field to `ShardBlock`
Co-authored-by: Danny Ryan <[email protected]>
… `process_shard_transitions`
I think this change more clearly specifies the intended behavior. Given the terseness of the spec's code representation, I think we should aim for as much clarity as possible.
..and use List[byte, 256] for error message
Update fork choice spec comment for clarity
Some phase1 refactoring
…sition Rework `Shard transition processing`
Co-authored-by: Danny Ryan <[email protected]>
Some phase1 refactoring - part2
Reword fork choice comment
…Y config value; fix tests
Co-authored-by: Diederik Loerakker <[email protected]>
clarify genesis finalized checkpoint root in p2p spec
Tunable genesis
Tidying up `shard_state_transition`
Use SSZ types in p2p spec
bump VERSION.txt to 0.12.1
protolambda
reviewed
Jun 2, 2020
| @@ -89,7 +89,6 @@ def test_success_double(spec, state): | |||
|
|
|||
| @with_all_phases | |||
| @spec_state_test | |||
| @never_bls | |||
| def test_success_surround(spec, state): | |||
There was a problem hiding this comment.
We need to regenerate this test in particular, now that BLS is re-enabled.
protolambda
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily tunable genesis time (#1866) and clarify genesis checkpoint root in p2p spec (#1867).
Beyond that, some comment fixes and continued Phase 1 dev