-
Notifications
You must be signed in to change notification settings - Fork 18
Add metrics useful for Partial Data Columns #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarcoPolo
wants to merge
1
commit into
ethereum:master
Choose a base branch
from
MarcoPolo:partial-columns-metrics
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,21 @@ The following metrics are proposed to be added to clients for PeerDAS monitoring | |
| | `beacon_engine_getBlobsV2_responses_total` | Counter | Total number of `engine_getBlobsV2` successful responses received | On receiving `engine_getBlobsV2` responses | | ||
| | `beacon_engine_getBlobsV2_request_duration_seconds` | Histogram | Duration of `engine_getBlobsV2` requests | On `engine_getBlobsV2` request completion | ||
|
|
||
| #### Partial Data Column metrics (aka Cell-Level Dissemination) | ||
|
|
||
| | Name | Metric type | Usage | Sample collection event | | ||
| | --------------------------------------------------- | ----------- | -------------------------------------------------------------------------------------- | ------------------------------------------ | | ||
| | `beacon_engine_getBlobsV3_requests_total` | Counter | Total number of `engine_getBlobsV3` requests sent | On sending `engine_getBlobsV2` requests | | ||
| | `beacon_engine_getBlobsV3_complete_responses_total` | Counter | Total number of complete `engine_getBlobsV3` successful responses received | On receiving `engine_getBlobsV2` responses | | ||
| | `beacon_engine_getBlobsV3_partial_responses_total` | Counter | Total number of `engine_getBlobsV3` partial responses received | On receiving `engine_getBlobsV3` responses | | ||
| | `beacon_engine_getBlobsV2_request_duration_seconds` | Histogram | Duration of `engine_getBlobsV3` requests | On `engine_getBlobsV2` request completion | | ||
| | `gossipsub_pubsub_rpc_sent_pub_size_total` | Counter | Total size of publish messages sent via RPC. Labels: `topic`, `is_partial` (bool) | On pubsub RPC publish | | ||
| | `gossipsub_mesh_partial_message_capable_peers` | Gauge | Number of partial-message capable peers in mesh. Labels: `topic` | On mesh peer update | | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lighthouse already had |
||
| | `beacon_partial_message_useful_cells_total` | Counter | Number of useful cells received via a partial message. Labels: `column_index` | On useful partial message reception | | ||
| | `beacon_partial_message_cells_received_total` | Counter | Number of total cells received via a partial message. Labels: `column_index` | On partial message reception | | ||
| | `beacon_useful_full_columns_received_total` | Counter | Number of useful full columns (any cell being useful) received. Labels: `column_index` | On useful full column reception | | ||
| | `beacon_partial_message_column_completions_total` | Counter | How often the partial message first completed the column. Labels: `column_index` | On column completion by partial message | | ||
|
|
||
| ### Additional Metrics | ||
|
|
||
| The following are proposed metrics to be added to clients. This list is _not_ stable and is subject to drastic changes, deletions, and additions. The additional metric list is being | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Lighthouse this already existed with
gossipsub_topic_msg_sent_bytes. I now added a field in the label to allow filtering forpartialmessages