Add metrics useful for Partial Data Columns#21
Open
MarcoPolo wants to merge 1 commit intoethereum:masterfrom
Open
Add metrics useful for Partial Data Columns#21MarcoPolo wants to merge 1 commit intoethereum:masterfrom
MarcoPolo wants to merge 1 commit intoethereum:masterfrom
Conversation
MarcoPolo
force-pushed
the
partial-columns-metrics
branch
from
168d816 to
f293d0e
Compare
dknopik
reviewed
Jan 14, 2026
MarcoPolo
force-pushed
the
partial-columns-metrics
branch
from
f293d0e to
8f64233
Compare
dknopik
reviewed
Jan 16, 2026
MarcoPolo
force-pushed
the
partial-columns-metrics
branch
from
8f64233 to
4e219ab
Compare
Author
|
One thing to consider, rust-libp2p already has had some of these metrics with a different name for a while. It would be a breaking change for them to rename it. It seems like our options are:
|
jxs
reviewed
Feb 6, 2026
| | `beacon_engine_getBlobsV3_complete_responses_total` | Counter | Total number of complete `engine_getBlobsV3` successful responses received | On receiving `engine_getBlobsV2` responses | | ||
| | `beacon_engine_getBlobsV3_partial_responses_total` | Counter | Total number of `engine_getBlobsV3` partial responses received | On receiving `engine_getBlobsV3` responses | | ||
| | `beacon_engine_getBlobsV2_request_duration_seconds` | Histogram | Duration of `engine_getBlobsV3` requests | On `engine_getBlobsV2` request completion | | ||
| | `gossipsub_pubsub_rpc_sent_pub_size_total` | Counter | Total size of publish messages sent via RPC. Labels: `topic`, `is_partial` (bool) | On pubsub RPC publish | |
There was a problem hiding this comment.
in Lighthouse this already existed with gossipsub_topic_msg_sent_bytes . I now added a field in the label to allow filtering for partial messages
| | `beacon_engine_getBlobsV3_partial_responses_total` | Counter | Total number of `engine_getBlobsV3` partial responses received | On receiving `engine_getBlobsV3` responses | | ||
| | `beacon_engine_getBlobsV2_request_duration_seconds` | Histogram | Duration of `engine_getBlobsV3` requests | On `engine_getBlobsV2` request completion | | ||
| | `gossipsub_pubsub_rpc_sent_pub_size_total` | Counter | Total size of publish messages sent via RPC. Labels: `topic`, `is_partial` (bool) | On pubsub RPC publish | | ||
| | `gossipsub_mesh_partial_message_capable_peers` | Gauge | Number of partial-message capable peers in mesh. Labels: `topic` | On mesh peer update | |
There was a problem hiding this comment.
Lighthouse already had gossipsub_mesh_peer_counts . I now added a field in the label to allow to filter supports_partial for peers that support partial messages on the topic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may add more things over time, but this is the first pass at obviously useful metrics.