update selections endpoint description - #368
Merged
Merged
Conversation
* edit api descriptions * cleanup * edit message
* update to mention lookahead epochs * clarify current and lookahead epochs * review comments
OisinKyne
approved these changes
Oct 27, 2023
OisinKyne
left a comment
OisinKyne
left a comment
Contributor
There was a problem hiding this comment.
Maybe we add my suggestion to make it apparent it doesn't have to be default behaviour, only when the VC is part of a cluster?
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
3 tasks
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Dec 19, 2025
…8669) **Motivation** Closes #8606 **Description** This updates our implementation to be compliant with latest spec ethereum/beacon-APIs#368. For sync committee aggregation selection (unchanged) - we call `submitSyncCommitteeSelections` at the start of the slot - the timeout is still based on `CONTRIBUTION_DUE_BPS` into the slot (8 seconds) - we call the endpoint for all duties of this slot - logic has been moved to duties service For attestation aggregation selection - we call `submitBeaconCommitteeSelections` at the start of the epoch for current and next epoch (2 separate calls) - the timeout uses default which is based on `SLOT_DURATION_MS` (12 seconds) - we only call `prepareBeaconCommitteeSubnet` once the above call either resolved or failed, this should be fine as it's not that time sensitive (one epoch lookahead) - if duties are reorged, we will call `submitBeaconCommitteeSelections` with duties of affected epoch - logic has been moved to duties service Previous PR #5344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update endpoint descriptions for the following selections endpoints:
/eth/v1/validator/beacon_committee_selections/eth/v1/validator/sync_committee_selectionsThis PR updates selection endpoint descriptions to explicitly state when to call these endpoints:
Note: This change eliminates confusion among client teams implementing these endpoints on when to query the selection endpoints.