Implement distributed aggregation selections - #5344
Merged
Merged
Conversation
nflaig
force-pushed
the
nflaig/dvt-aggregation-selections
branch
from
April 5, 2023 12:08
8899e32 to
bbbf68b
Compare
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
force-pushed
the
nflaig/dvt-aggregation-selections
branch
6 times, most recently
from
April 5, 2023 22:07
f5be68e to
19342ae
Compare
nflaig
force-pushed
the
nflaig/dvt-aggregation-selections
branch
from
April 5, 2023 22:10
19342ae to
c3977a8
Compare
nflaig
force-pushed
the
nflaig/dvt-aggregation-selections
branch
from
April 6, 2023 11:43
c3977a8 to
2ad316e
Compare
nflaig
marked this pull request as ready for review
April 6, 2023 11:58
wemeetagain
previously approved these changes
Apr 6, 2023
wemeetagain
left a comment
wemeetagain
left a comment
Member
There was a problem hiding this comment.
Logic looks good to me. Good job with the helpful comments and generally clean code.
Leaving open for another pair of eyes.
Member
Author
|
Thanks for the review @wemeetagain! Yeah please let it open, still want to add unit tests and wait for more results from Obol testing this on their cluster |
matthewkeil
previously approved these changes
Apr 6, 2023
matthewkeil
left a comment
matthewkeil
left a comment
Member
There was a problem hiding this comment.
The code looks awesome and the comments were even better. Approving for code structure and high-fiving for quality! Reading the spec and implementation notes to familiarize myself.
nflaig
commented
Apr 8, 2023
nflaig
commented
Apr 8, 2023
nflaig
force-pushed
the
nflaig/dvt-aggregation-selections
branch
from
April 14, 2023 15:07
e4925ec to
78155a7
Compare
Member
Author
|
Obol has successfully tested Lodestar on their cluster 🚀
|
wemeetagain
approved these changes
Apr 14, 2023
wemeetagain
left a comment
wemeetagain
left a comment
Member
There was a problem hiding this comment.
Read thru again. LGTM
Again great attention to detail.
Member
|
🎉 This PR is included in v1.8.0 🎉 |
nflaig
added a commit
that referenced
this pull request
Dec 19, 2025
…8669) **Motivation** Closes #8606 **Description** This updates our implementation to be compliant with latest spec ethereum/beacon-APIs#368. For sync committee aggregation selection (unchanged) - we call `submitSyncCommitteeSelections` at the start of the slot - the timeout is still based on `CONTRIBUTION_DUE_BPS` into the slot (8 seconds) - we call the endpoint for all duties of this slot - logic has been moved to duties service For attestation aggregation selection - we call `submitBeaconCommitteeSelections` at the start of the epoch for current and next epoch (2 separate calls) - the timeout uses default which is based on `SLOT_DURATION_MS` (12 seconds) - we only call `prepareBeaconCommitteeSubnet` once the above call either resolved or failed, this should be fine as it's not that time sensitive (one epoch lookahead) - if duties are reorged, we will call `submitBeaconCommitteeSelections` with duties of affected epoch - logic has been moved to duties service Previous PR #5344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implements ethereum/beacon-APIs#224 based on guide, closes #5334
Description
Additional context