Add ERC: Chain-Specific Payment Requests #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
✅ All reviewers have approved. |
|
The commit 6346cdb (as a parent of 849726a) contains errors. |
16 tasks
18 tasks
18 tasks
SamWilsn
approved these changes
Mar 20, 2025
Contributor
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
Good for a draft. Apply these suggestions at your leisure.
| --- | ||
| eip: 7856 | ||
| title: Chain-Specific Payment Requests | ||
| description: A URI scheme for chain-specific payment requests. |
Contributor
There was a problem hiding this comment.
URI scheme
This is good. It adds new information.
for chain-specific payment requests.
This is just restating the title. You should use the description to expand on the title.
|
|
||
| ## Abstract | ||
|
|
||
| This EIP proposes a standardized URI scheme for chain-specific payment requests, enabling users to specify transactions in the form "send me X tokens of type Y on chain Z". The URI format includes essential components such as the recipient's blockchain account, the amount of tokens, the token contract address, and optional success and error callback URLs. This standard aims to eliminate ambiguity in multi-chain payment requests, ensuring clarity and accuracy in peer-to-peer transactions and vendor or dApp requests across different blockchain networks. |
Contributor
There was a problem hiding this comment.
Just a suggestion, but you could include an example of the URL format in the abstract.
| ``` | ||
|
|
||
| - `cspr://` - [REQUIRED] Short for "Chain-Specific Payment Request". Indicates a blockchain-based payment request. | ||
| - `<recipient>` - [REQUIRED] The blockchain account requesting the payment (represented as a CAIP-10 account identifier). |
Contributor
There was a problem hiding this comment.
Suggested change
| - `<recipient>` - [REQUIRED] The blockchain account requesting the payment (represented as a CAIP-10 account identifier). | |
| - `<recipient>` - [REQUIRED] The blockchain account requesting the payment (represented as a [CAIP-10](https://github.com/ChainAgnostic/CAIPs/blob/b23e772369f2bc885c2ab70af4f0a0ec6bff6631/CAIPs/caip-10.md) account identifier). |
eip-review-bot
approved these changes
Mar 20, 2025
Collaborator
eip-review-bot
left a comment
eip-review-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This EIP proposes a URI scheme for chain-specific payment requests, enabling users to specify transactions in the form "send me X tokens of type Y on chain Z". The URI format includes essential components such as the recipient's blockchain account, the amount of tokens, the token contract address, and optional success and error callback URLs. This standard aims to eliminate ambiguity in multi-chain payment requests, ensuring clarity and accuracy in peer-to-peer transactions and vendor or dApp requests across different blockchain networks.