Add ERC: Wallet Connection API #779

ilikesymmetry · 2024-12-17T03:02:11Z

This proposal defines a new RPC for wallet connection with an emphasis on extensibility. Builds on the notion of optional “capabilities” defined in ERC-5792 to add new functionality modularly. This proposal defines one capability to reduce separate interactions for connection and authentication, but otherwise seeks to leave capability definitions open-ended.

eip-review-bot · 2024-12-17T03:02:42Z

✅ All reviewers have approved.

ERCS/erc-draft-wallet-connection-api.md

jxom · 2024-12-18T03:59:58Z

ERCS/erc-draft-wallet-connection-api.md

+type WalletConnectResult = {
+  account: {
+    address: `0x${string}`; // connected account address
+    supportedChainsAndCapabilities: Record<`0x${string}`,any>; // chain-specific capabilities, mirrors ERC-5792 wallet_getCapabilities


Suggested change

supportedChainsAndCapabilities: Record<`0x${string}`,any>; // chain-specific capabilities, mirrors ERC-5792 wallet_getCapabilities

chains: `0x${string}`[]; // supported chains

Should this just be an array of supported chains? Consumers can use wallet_getCapabilities to extract capabilities from a Wallet.

The intent was to remove the need to make a separate wallet_getCapabilities request. That may not be necessary at API layer though because SDKs could do this automatically for apps.

ERCS/erc-draft-wallet-connection-api.md

jxom · 2024-12-21T15:04:26Z

ERCS/erc-7846.md

+}
+
+type SignInWithEthereumCapabilityResult = {
+  message: string, // formatted SIWE message


Might also be nice to add a payload property so consumers don't have to parse the message string to figure out the inferred parameters (e.g. address, domain, etc)?

Suggested change

message: string, // formatted SIWE message

message: string, // formatted SIWE message

payload: {

address: `0x{string}`,

nonce: string,

...

},

devil's advocate, consumers not using the ABNF to parse it are risking all kinds of security problems, payload and message could fall out of sync (which is itself just an additional surface to secure), etc etc

Wdym? If they are out of sync, then signature verification will fail.

ghost

Need changes

feat: `wallet_disconnect` + structure improvements

pedrouid · 2025-01-08T23:00:57Z

While I understand the motivation for creating EVM-specific standards for Wallets... there is nothing new or extra that ERC-7846 provides that isn't already covered by CAIP-222

https://chainagnostic.org/CAIPs/caip-222

Why restrict such an important pattern like "Connect + Sign" to only EVM wallets?

johanneskares · 2025-01-09T09:46:58Z

This proposal defines a new RPC for wallet connection with an emphasis on extensibility. Builds on the notion of optional “capabilities” defined in ERC-5792 to add new functionality modularly. This proposal defines one capability to reduce separate interactions for connection and authentication, but otherwise seeks to leave capability definitions open-ended.

one huge problem still:

For passkey wallets, e.g. Signing Up with Coinbase Smart Wallet, you would still need 2 interactions with this ERC. First TouchID to get the Ethereum Address, second one to sign the message. Sign In With Ethereum is not a good solution. The address should not be part of the signed message. It's implicit from the signature.

I'd suggest changing this ERC to allow signing an arbitrary message, makes it simpler and leaves the kind of signature to the dApp.

bumblefudge · 2025-01-19T15:57:31Z

Why restrict such an important pattern like "Connect + Sign" to only EVM wallets?

I would tend to agree that having a multi-VM/multi-L1 syntax for every context except EVM and an EVM-specific context is needlessly inharmonious, if using the CAIP-222 RPC message would be functionally identical to this bespoke one.

That said, we have an ERC here that seems to work, and are comparing it to the hypothetical ERC which achieves the same properties with a CAIP-222-conformant message. Would it help to write a competing ERC that has all the same properties and additional can be parsed by a multi-chain/CAIP-222 system like WalletConnect's? I'd rather not be the one to write it, but if no one else is offering AND evaluators of this ERC would appreciate an apples-to-apples ERC, I can write one... who knows, maybe the exercise of writing out CAIP-222 as an ERC for EVM-specific contexts will tease out subtle differences?

SamWilsn · 2025-03-02T08:35:58Z

ERCS/erc-7846.md

@@ -0,0 +1,233 @@
+--- 
+eip: 7846
+title: Wallet Connection API  


I know there isn't a ton of room in the title (44 characters IIRC), but it would be nice if you could cram a bit more detail in here to help disambiguate.

Would prefer to keep it as-is to be consistent with 5792 (Wallet Call API)

But if you feel strongly that we should disambiguate further then I'd suggest "Wallet Connection API with Capabilities"

SamWilsn · 2025-03-02T08:37:10Z

ERCS/erc-7846.md

+
+## Abstract
+
+This ERC introduces a new wallet connection JSON-RPC method focused on extensibility. It leverages the modular capabilities approach defined in [ERC-5792](https://eips.ethereum.org/EIPS/eip-5792#wallet_getcapabilities) to streamline connections and authentication into a single interaction.


You should mention the specific endpoint in the abstract, and have maybe a bit more technical detail here. An abstract is not an introduction.

SamWilsn · 2025-03-02T08:40:12Z

ERCS/erc-7846.md

+
+#### `signInWithEthereum`
+
+Adds support for offchain authentication using [ERC-4361: Sign-In with Ethereum](https://eips.ethereum.org/EIPS/eip-4361).


You'll need to use a relative link. Something like:

Suggested change

Adds support for offchain authentication using [ERC-4361: Sign-In with Ethereum](https://eips.ethereum.org/EIPS/eip-4361).

Adds support for offchain authentication using [ERC-4361](./eip-4361.md).

SamWilsn · 2025-03-02T08:41:29Z

ERCS/erc-7846.md

+
+Same as ERC-4361 specification with minor modifications: 
+* The casing of multi-word fields has been adjusted to camelCase instead of kebab-case. Resources are an array field. 
+* The account address returned by `wallet_connect` MUST match the address inferred in the SIWE message.


You should expand the abbreviation the first time it is used:

Suggested change

* The account address returned by `wallet_connect` MUST match the address inferred in the SIWE message.

* The account address returned by `wallet_connect` MUST match the address inferred in the Sign-In with Ethereum (SIWE) message.

ERCS/erc-7846.md

SamWilsn · 2025-03-02T08:42:56Z

ERCS/erc-7846.md

+
+## Copyright
+
+Copyright and related rights waived via CC0.  


Please use the exact waiver from the template.

Genebond

Review

glitch-txs

I really like this EIP, it removes friction from the users that need to auth as well as adding a disconnect method which has been always needed in the current standard (1193).

I like that it mentions that future EIP's might extend capabilities. Which makes the EIP flexible without introducing breaking changes.

The DX looks nice and simple!

In the future I would personally like to be added an option to submit transaction requests right away together with the "wallet_connect" request. Even batching, which I think the wallet could internally handle in its own way (in case it supports it or just running them "synchronously"). I think this would be particularly useful for "one action" (and not one transaction) user needs, like Swapping or payments.

glitch-txs · 2025-05-22T13:54:49Z

ERCS/erc-7846.md

+
+```ts
+type Request = {
+  method: 'wallet_disconnect'


should we add optional params in case the user wants to disconnect only specific accounts? or would it be too much.

glitch-txs · 2025-05-22T14:06:42Z

ERCS/erc-7846.md

+
+## Rationale
+
+### Multiple Accounts


Should we add a method to request an accounts switch? To change the targeted account.
In such case should the wallet emit accountsChanged with the order of the accounts array altered?

Also, what if the user is connected with account A but now also wants the connect with B such that A and B are both connected? This has been something pretty much requested from dapp devs and we are using a workaround that only works with MetaMask AFAIK.

Maybe we should add specifications for wallets around this behavior, "wallet_connect" could be called by the dapp more than once to update the state of the connected accounts.

glitch-txs · 2025-05-22T14:29:28Z

ERCS/erc-7846.md

+
+Disconnects connected account(s).
+
+- The wallet SHOULD revoke any capabilities associated with the account(s) that were granted upon connection via `wallet_connect`.


Suggested change

- The wallet SHOULD revoke any capabilities associated with the account(s) that were granted upon connection via `wallet_connect`.

- The wallet SHOULD revoke access to the user account(s) information, as well as to any capabilities associated with them that were granted upon connection via `wallet_connect`.

fix: PR comments

github-actions · 2025-06-12T16:35:28Z

The commit d91b259 (as a parent of 5fa6bd2) contains errors.
Please inspect the Run Summary for details.

fix: lint issues

stephancill · 2025-06-16T16:29:47Z

Hi @SamWilsn and @glitch-txs thanks for the feedback. I've worked with @ilikesymmetry to update the PR

SamWilsn · 2025-07-08T16:26:13Z

ERCS/erc-7846.md

+---
+eip: 7846
+title: Wallet Connection API
+description: Adds JSON-RPC method for requesting wallet connection with modular capabilities.


Minor nit, but you repeat "wallet connection" from the title in your description. It might be better to reword it so the reader knows what a "wallet connection" is.

eip-review-bot

All Reviewers Have Approved; Performing Automatic Merge...

ilikesymmetry added 2 commits December 15, 2024 22:58

Add initial draft of Wallet Connection API

db3b787

Add discussions-to TBD

ed25a89

ilikesymmetry requested a review from eip-review-bot as a code owner December 17, 2024 03:02

eip-review-bot added e-consensus e-review labels Dec 17, 2024

Add discussion link

25c662e

github-actions bot added the w-ci label Dec 17, 2024

ilikesymmetry added 2 commits December 16, 2024 22:26

Add codeblock type and make minor edits

a97ac05

Thanks chatgpt

21e3bd2

abcoathup reviewed Dec 17, 2024

View reviewed changes

ERCS/erc-draft-wallet-connection-api.md Outdated Show resolved Hide resolved

abcoathup reviewed Dec 17, 2024

View reviewed changes

ERCS/erc-draft-wallet-connection-api.md Outdated Show resolved Hide resolved

Add number 7846

0d97ffe

jxom reviewed Dec 18, 2024

View reviewed changes

ilikesymmetry changed the title ~~Add ERC: Wallet Connection API~~ Add ERC-7846: Wallet Connection API Dec 20, 2024

ilikesymmetry added 3 commits December 20, 2024 13:57

Remove from mdx meta

9053be2

Make result multi-account and remove dependency with getCapabilities

294c5eb

Update signInWithEthereum capability fields to be maximally optional

4e4b001

github-actions bot added w-ci and removed w-ci labels Dec 20, 2024

jxom reviewed Dec 21, 2024

View reviewed changes

ghost suggested changes Dec 31, 2024

View reviewed changes

ilikesymmetry and others added 7 commits January 6, 2025 09:52

Update authors

2419fd7

feat: add wallet_disconnect + cleanup

c744ba7

up

aff00cb

up

4ce54a0

up

9ad67aa

up

b73d125

Merge pull request #2 from jxom/wallet-connection-api-2

abd1c9f

feat: `wallet_disconnect` + structure improvements

johanneskares approved these changes Jan 9, 2025

View reviewed changes

SamWilsn reviewed Mar 2, 2025

View reviewed changes

jxom mentioned this pull request May 5, 2025

feat(experimental): add connect + disconnect actions wevm/viem#3619

Merged

github-actions bot mentioned this pull request May 5, 2025

chore: version package wevm/viem#3622

Merged

Genebond suggested changes May 6, 2025

View reviewed changes

Genebond approved these changes May 6, 2025

View reviewed changes

glitch-txs reviewed May 22, 2025

View reviewed changes

stephancill and others added 4 commits June 3, 2025 21:17

fix: PR comments

713214c

Update erc-7846.md

1000612

Update erc-7846.md

3e89fa9

Merge pull request #3 from stephancill/wallet-connection-api

d91b259

fix: PR comments

stephancill and others added 2 commits June 12, 2025 18:57

fix: lint issues

000b07a

Merge pull request #4 from stephancill/wallet-connection-api

5ac1521

fix: lint issues

github-actions bot added c-new s-draft t-erc labels Jun 16, 2025

eip-review-bot changed the title ~~Add ERC-7846: Wallet Connection API~~ Add ERC: Wallet Connection API Jun 16, 2025

github-actions bot removed the w-ci label Jun 16, 2025

ilikesymmetry requested review from SamWilsn and abcoathup June 16, 2025 17:15

poojaranjan mentioned this pull request Jun 27, 2025

EIP Editing Office Hour Meeting 64 (EIP + ERC ) | July 08, 2025 ethereum/pm#1596

Closed

37 tasks

SamWilsn approved these changes Jul 8, 2025

View reviewed changes

eip-review-bot enabled auto-merge (squash) July 8, 2025 16:34

eip-review-bot approved these changes Jul 8, 2025

View reviewed changes

eip-review-bot merged commit 8a16bc7 into ethereum:master Jul 8, 2025
15 of 16 checks passed

	supportedChainsAndCapabilities: Record<`0x${string}`,any>; // chain-specific capabilities, mirrors ERC-5792 wallet_getCapabilities
	chains: `0x${string}`[]; // supported chains

-  message: string, // formatted SIWE message
+  message: string, // formatted SIWE message
+  payload: {
+    address: `0x{string}`,
+    nonce: string,
+    ...
+  },


		## Abstract

		This ERC introduces a new wallet connection JSON-RPC method focused on extensibility. It leverages the modular capabilities approach defined in [ERC-5792](https://eips.ethereum.org/EIPS/eip-5792#wallet_getcapabilities) to streamline connections and authentication into a single interaction.


		#### `signInWithEthereum`

		Adds support for offchain authentication using [ERC-4361: Sign-In with Ethereum](https://eips.ethereum.org/EIPS/eip-4361).

	* The account address returned by `wallet_connect` MUST match the address inferred in the SIWE message.
	* The account address returned by `wallet_connect` MUST match the address inferred in the Sign-In with Ethereum (SIWE) message.


		Disconnects connected account(s).

		- The wallet SHOULD revoke any capabilities associated with the account(s) that were granted upon connection via `wallet_connect`.

	- The wallet SHOULD revoke any capabilities associated with the account(s) that were granted upon connection via `wallet_connect`.
	- The wallet SHOULD revoke access to the user account(s) information, as well as to any capabilities associated with them that were granted upon connection via `wallet_connect`.

Add ERC: Wallet Connection API #779

Add ERC: Wallet Connection API #779

Uh oh!

Conversation

ilikesymmetry commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eip-review-bot commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

pedrouid commented Jan 8, 2025

Uh oh!

johanneskares commented Jan 9, 2025

Uh oh!

bumblefudge commented Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Genebond left a comment

Choose a reason for hiding this comment

Uh oh!

glitch-txs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

glitch-txs May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

stephancill commented Jun 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eip-review-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

ilikesymmetry commented Dec 17, 2024 •

edited

Loading

eip-review-bot commented Dec 17, 2024 •

edited

Loading

bumblefudge commented Jan 19, 2025 •

edited

Loading

glitch-txs left a comment •

edited

Loading

glitch-txs May 22, 2025 •

edited

Loading