feat: wallet_disconnect + structure improvements
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxom
changed the title
wallet_disconnect + cleanupwallet_disconnect + structure improvements
|
|
||
| Disconnects connected account(s). | ||
|
|
||
| - The wallet SHOULD revoke any capabilities associated with the account(s) that were granted upon connection via `wallet_connect`. |
Owner
There was a problem hiding this comment.
Need to think more on this. May be comingling things too much. If I log out of Coinbase, that doesn't mean I want to disconnect my connection to my bank account if I set that up on login (attempt at analogy to combining with a session/permission example).
ilikesymmetry
approved these changes
Jan 7, 2025
Owner
ilikesymmetry
left a comment
ilikesymmetry
left a comment
There was a problem hiding this comment.
optimistically merging, thanks for the good edits :)
ilikesymmetry
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Create erc.md * Rename erc.md to erc-permissionless_create2_factory.md * Add discussion link * Fix Minor Typo Just fixes a small inconsistency where we were using `||` and `++` for byte concatenation. Prefer the former. * Fix Heading for 3rd Existing Method * Add More Context about Using Private Key (#2) * Minor Edits - Remove duplicate linking to EIP-7702 (only first one should be linked) - Remove trailing whitespace - Fix spelling error * Fix Requires Reference Requires should be _just_ numbers without the `EIP-` or `ERC-` prefix. This causes issues with the generated HTLM and proofer. * Title Case Sections Fixed some section titles that weren't titlecased correctly. * Use `RETURNDATASIZE` Instead of `PUSH0` In order to not depend on EIP-3855 `PUSH0` opcode, we refactor the factory code to use `RETURNDATASIZE` which is guaranteed to be `0` **except** for when `CREATE2` reverts. With a little bit of moving code around, we also managed to change make the code one byte smaller and fit into a 32-byte word. * Typos * Use eip number * Fix Section Lint The ERC lint does not like additional top level sections, so move the "custom" forwards compatibility section into a subsection of the backwards compatibility * Remove Non-relative Links We remove all non-relative links, as the ERC linter does not allow them. This is slightly unfortunate, since they did provide additional context to the ERC, but 🤷. Note that we format GitHub repositories with italicized title and code for them to stand out: ``` _Title_ (`org/repo`) ``` * Edits to ERC (#4) * Edits to ERC This PR implements the suggested edits to the ERC, and adds a new section explaining the rationale why Nick's method cannot be used for generating the EIP-7702 authorization signature (since it was a question on Ethereum magicians). * Some small follow-up edits * Another small edit * Clarify reverts cause. Co-authored-by: Shebin John <[email protected]> --------- Co-authored-by: Shebin John <[email protected]> * Fix Description The description included a forbidden word, remove it. --------- Co-authored-by: Nicholas Rodrigues Lordello <[email protected]> Co-authored-by: Nicholas Rodrigues Lordello <[email protected]> Co-authored-by: Shebin John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggesting the following:
wallet_disconnectJSON-RPC method.