Update ERC-4337: Move to Review #1014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eip-review-bot
changed the title
17 tasks
SamWilsn
reviewed
Apr 29, 2025
Contributor
SamWilsn
left a comment
SamWilsn
left a comment
There was a problem hiding this comment.
- Line 20: You'll need to remove the link in backticks.
- Line 20: The reference to EIP-2938 needs to be resolved before moving into review, where "resolved" means either removing the reference or getting EIP-2938 withdrawn.
- Line 48: I'd recommend against putting a requirement ("MUST") in your definitions section. They are easy to miss.
- Line 54: Same.
- Line 55: EIP-7732 is still a Draft. It'll have to advance to Review before 4337 does (or you can remove the reference).
- Line 56: Same comment about 7796 (either move it to review or remove the reference)
- I'm going to stop mentioning these, but any link to a Draft/Stagnant proposal needs to either: be removed, or the referenced proposal needs to be moved to Review/Withdrawn.
- Lines 60-61: Should "UserOperation" be in backticks (`)?
- Line 64: Same
- Line 72: Is
0x7702left-padded or right-padded to 20 bytes? - Line 237: Less of an editorial comment and more technical, but why is this a SHOULD and not a MUST?
- Line 583: You'll need to remove this link. You can put you reference implementation in your assets directory provided it is under a permissive license.
Co-authored-by: Sam Wilson <[email protected]>
29 tasks
53 tasks
37 tasks
Contributor
|
I assume you're still interested in this PR? |
Contributor
3 tasks
3 tasks
3 tasks
3 tasks
Collaborator
|
The status change has been merged on #1157 Can we update the branch to sync with |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.