Update EIP-7002: fix variable name typo in withdrawal requests dequeue function #9768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
✅ All reviewers have approved. |
29 tasks
lightclient
approved these changes
May 13, 2025
eth-bot
approved these changes
May 13, 2025
Collaborator
eth-bot
left a comment
eth-bot
left a comment
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a variable name inconsistency in the
dequeue_withdrawal_requestsfunction. The variable was assigned asnum_dequeuedbut then referenced asnum_dequeuein the for loop, which would cause an undefined variable reference.Changes
for i in range(num_dequeue):tofor i in range(num_dequeued):to correctly reference the previously defined variableTesting
The fix maintains the intended functionality of the withdrawal request system while preventing potential errors during execution.