Skip to content

Conversation

@forshtat
Copy link
Contributor

@forshtat forshtat commented Feb 28, 2025

Reopening the old PR that I did not realise was not previously merged (#7968)

This proposal is significantly different from EIP-7863 (#9246), arguably presents a more complete and fair solution that is worth the extra complexity, and precedes it for more than a year.

@forshtat forshtat requested a review from eth-bot as a code owner February 28, 2025 18:24
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Feb 28, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 28, 2025

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Feb 28, 2025
@github-actions
Copy link

The commit c23394e (as a parent of b1d9e19) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 28, 2025
@eth-bot eth-bot changed the title Add EIP: Block-level Warming with fair distribution of cost savings Add EIP: Block-level Warming with fair cost savings Feb 28, 2025
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 28, 2025
Copy link

@bomanaps bomanaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kindly take a look at the lining format. Usually, you start a new sentence on a new line.


### Calculating a reimbursement of the charged priority fee

Each transaction pays an individual `priorityFeePerGas` value and redistributing this part of the cold access cost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each tx pays priority + base fee, you only applying warming on priority fee?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as the base fee is same for all transactions in a block it is easy to just split the cost. Priority fee is different and we need some kind of a formula to redistribute its costs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but you are not reimbursing whatever is the extra base fee for already warmed stuff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, we reimburse the base fee by redistributing all the base fee collected to all transactions accessing the storage, this is described in ### Calculating a reimbursement of the burned base fee. Maybe you could suggest a better way to define this behaviour?

@forshtat
Copy link
Contributor Author

forshtat commented Apr 1, 2025

Hello @bomanaps and thank you for the review. I have removed the use of \ as a line break, and fixed a few long lines containing multiple sentences.
However, I am not sure I can agree with your suggestion of using the newline only to separate sentences. As sentences can become very long in these technical documents and especially when using git to manage versions of these documents, long lines create an inconvenience while having absolutely no observable effect on the rendered markdown file.
Please advise if this is a strong requirement for the EIPs to be merged going forward or if it is just a suggestion.
Thanks.

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go for a draft. Do address these comments before moving into Review.

---
eip: 7557
title: Block-level Warming with fair cost savings
description: Block-level warming of addresses and slots with access lists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a bit more room (144 characters) in your description. You should expand and give a bit more detail.

Comment on lines +15 to +16
A mechanism for a fair distribution of the gas costs associated with access to addresses and storage slots
among multiple transactions with shared items in their `accessList`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The abstract should contain a brief (but still technical) overview of the proposal. Can you sketch out the mechanism here without getting too in the weeds?

@eth-bot eth-bot enabled auto-merge (squash) April 1, 2025 16:42
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 71272fc into ethereum:master Apr 1, 2025
12 checks passed
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants