-
Notifications
You must be signed in to change notification settings - Fork 6k
Add EIP: Block-level Warming with fair cost savings #9428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Block-level Warming with fair cost savings #9428
Conversation
|
✅ All reviewers have approved. |
|
The commit c23394e (as a parent of b1d9e19) contains errors. |
bomanaps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please kindly take a look at the lining format. Usually, you start a new sentence on a new line.
|
|
||
| ### Calculating a reimbursement of the charged priority fee | ||
|
|
||
| Each transaction pays an individual `priorityFeePerGas` value and redistributing this part of the cold access cost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each tx pays priority + base fee, you only applying warming on priority fee?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as the base fee is same for all transactions in a block it is easy to just split the cost. Priority fee is different and we need some kind of a formula to redistribute its costs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you are not reimbursing whatever is the extra base fee for already warmed stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, we reimburse the base fee by redistributing all the base fee collected to all transactions accessing the storage, this is described in ### Calculating a reimbursement of the burned base fee. Maybe you could suggest a better way to define this behaviour?
|
Hello @bomanaps and thank you for the review. I have removed the use of |
SamWilsn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go for a draft. Do address these comments before moving into Review.
| --- | ||
| eip: 7557 | ||
| title: Block-level Warming with fair cost savings | ||
| description: Block-level warming of addresses and slots with access lists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a bit more room (144 characters) in your description. You should expand and give a bit more detail.
| A mechanism for a fair distribution of the gas costs associated with access to addresses and storage slots | ||
| among multiple transactions with shared items in their `accessList`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The abstract should contain a brief (but still technical) overview of the proposal. Can you sketch out the mechanism here without getting too in the weeds?
eth-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
eth-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Reopening the old PR that I did not realise was not previously merged (#7968)
This proposal is significantly different from EIP-7863 (#9246), arguably presents a more complete and fair solution that is worth the extra complexity, and precedes it for more than a year.