Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-5792: add CAIP-25 normref to eip-5792 #8624

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

bumblefudge
Copy link
Contributor

Hey all:

Hopefully a minor, no-brainer PR to link to CAIP-25 from the sentence mentioning it. Thanks to @GregTheGreek for driving the EIP1 PR permitting links to CAIPs! I think the EIP bot should tag all the authors next so I won't bother doing it manually here as well.

Note: Last Call ends in 3 weeks on this EIP!

@bumblefudge bumblefudge requested a review from eth-bot as a code owner June 5, 2024 18:46
@github-actions github-actions bot added c-update Modifies an existing proposal t-interface labels Jun 5, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 5, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the a-review Waiting on author to review label Jun 5, 2024
@eth-bot eth-bot changed the title add CAIP-25 normref to eip-5792 Update EIP-5792: add CAIP-25 normref to eip-5792 Jun 5, 2024
@GregTheGreek
Copy link
Contributor

Wooo love to see it getting used :)

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Jun 10, 2024
@github-actions github-actions bot added c-status Changes a proposal's status and removed c-update Modifies an existing proposal labels Aug 8, 2024
@eth-bot eth-bot changed the title Update EIP-5792: add CAIP-25 normref to eip-5792 CI: add CAIP-25 normref to eip-5792 Aug 8, 2024
@eth-bot eth-bot changed the title CI: add CAIP-25 normref to eip-5792 Update EIP-5792: add CAIP-25 normref to eip-5792 Aug 8, 2024
@eth-bot eth-bot enabled auto-merge (squash) August 8, 2024 13:06
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit b9b3f41 into ethereum:master Aug 8, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-status Changes a proposal's status e-consensus Waiting on editor consensus t-interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants