-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5792: add CAIP-25 normref to eip-5792 #8624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All reviewers have approved. |
eth-bot
changed the title
add CAIP-25 normref to eip-5792
Update EIP-5792: add CAIP-25 normref to eip-5792
Jun 5, 2024
Wooo love to see it getting used :) |
to add .github
github-actions
bot
added
c-status
Changes a proposal's status
and removed
c-update
Modifies an existing proposal
labels
Aug 8, 2024
eth-bot
changed the title
Update EIP-5792: add CAIP-25 normref to eip-5792
CI: add CAIP-25 normref to eip-5792
Aug 8, 2024
eth-bot
changed the title
CI: add CAIP-25 normref to eip-5792
Update EIP-5792: add CAIP-25 normref to eip-5792
Aug 8, 2024
lukasrosario
approved these changes
Aug 8, 2024
eth-bot
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a-review
Waiting on author to review
c-status
Changes a proposal's status
e-consensus
Waiting on editor consensus
t-interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all:
Hopefully a minor, no-brainer PR to link to CAIP-25 from the sentence mentioning it. Thanks to @GregTheGreek for driving the EIP1 PR permitting links to CAIPs! I think the EIP bot should tag all the authors next so I won't bother doing it manually here as well.
Note: Last Call ends in 3 weeks on this EIP!