Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1: Feat/add caip #8247

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Conversation

GregTheGreek
Copy link
Contributor

@GregTheGreek GregTheGreek commented Feb 20, 2024

This PR adds support for Chain Agnostic Improvement Proposals (CAIPs) as valid external links. Chain Agnostic Improvement Proposals (CAIPs) describe standards for blockchain projects that are not specific to a single chain.

Namely, one of the most important CAIPs is CAIP-2 and CAIP-10 which allow for deeply specified address from various different blockchians.

The current limitation of not having CAIPs specified is we get half baked proposals such as ERC-3770 which take us half-way to the full solution, but stop short. For reference, 3770 was heavily inspired by CAIP-10, and has notably prevented users from pasting incorrect address across networks.

WalletConnect also comes with CAIP support by default, and thus any dapp using wallet connect automatically conforms to CAIP25, CAIP2, CAIP10.

With the rise of L2s, bridges, and AA tools, we're seeing an immediate demand for having a stronger set of defined standards for navigating this space, one which probably shouldn't be explicitly specified within the EIPs/ERCs as they related to more than just Ethereum.

Decision on this PR is a dependent to merge erc-7555

@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Feb 20, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 20, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Feb 20, 2024
@eth-bot eth-bot changed the title Feat/add caip Update EIP-1: Feat/add caip Feb 20, 2024
@pedrouid
Copy link
Contributor

This would be a great initiative! As we already have other synergies as for example regarding CAIP-122 which generalizes EIP-4361 for any chain ecosystem

@GregTheGreek GregTheGreek marked this pull request as ready for review February 20, 2024 13:00
EIPS/eip-1.md Outdated Show resolved Hide resolved
Co-authored-by: Bumblefudge <[email protected]>
@GregTheGreek
Copy link
Contributor Author

@SamWilsn I've updated your requested changes. Is there somewhere to discuss this further?

@SamWilsn
Copy link
Contributor

Would you mind updating this and this? If so, we can get this merged.

@GregTheGreek
Copy link
Contributor Author

@SamWilsn Added both exclusions to EIP and ERC repos

@GregTheGreek
Copy link
Contributor Author

@SamWilsn Thanks for merging ERC's one last one :))

Copy link

github-actions bot commented May 8, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 8, 2024
@GregTheGreek
Copy link
Contributor Author

@SamWilsn smol bump

@github-actions github-actions bot removed the w-stale Waiting on activity label May 19, 2024
@eth-bot eth-bot enabled auto-merge (squash) June 5, 2024 17:56
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 32dc740 into ethereum:master Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants