feat: introduce templates for vaults upgrade and revenue share opt in#1257
Merged
maurelian merged 56 commits intoNov 17, 2025
Merged
Conversation
chore: sync branch revshare
maurelian
reviewed
Oct 21, 2025
maurelian
reviewed
Oct 23, 2025
maurelian
reviewed
Oct 23, 2025
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
maurelian
reviewed
Nov 14, 2025
maurelian
reviewed
Nov 14, 2025
maurelian
previously approved these changes
Nov 14, 2025
maurelian
reviewed
Nov 17, 2025
Co-authored-by: Maurelian <john@oplabs.co>
maurelian
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a new
RevShareContractsUpgraderon-chain contract containing all the upgrade logic for deploying and upgrading revenue sharing, and also one template to execute it using multiple chains as inputs.Currently, we only have a template for the main flow, which is inside the
upgradeAndSetupRevShare()function. The template for thesetupRevShare()will be added in another PR. This flow has lower priority since it is not a flow we need to cover now, but the logic is there in the contract because it will probably be needed in the future.Tests
We added comprehensive unit test coverage for the contract, and most importantly, we wrote some integration tests using Supersim to check the state in L2 when deposits arrive there, combining the template and the upgrader contract.
Metadata
FeesDepositoraddress on deployer upon deployment optimism#17505.Authors
@0xChin @0xiamflux @0xDiscotech