Skip to content

chore: updates the bytecode for vaults, using initialize#31

Merged
0xDiscotech merged 8 commits into
sc-feat/revshare-setupfrom
chore/initialize-vaults-over-constructor
Oct 16, 2025
Merged

chore: updates the bytecode for vaults, using initialize#31
0xDiscotech merged 8 commits into
sc-feat/revshare-setupfrom
chore/initialize-vaults-over-constructor

Conversation

@0xiamflux
Copy link
Copy Markdown

@0xiamflux 0xiamflux commented Oct 14, 2025

Update vault bytecode to use initialize

Updates the bytecode for fee vaults to use an initialize function instead of constructor for vaults initialization.

Changes:

  • Updated RevShareCodeRepo.sol with new vault bytecode
  • Modified RevenueShareUpgradePath.sol to use initialize pattern

Important: Holding off updates on Regression test once the code is ready to be merged.

Closes OPT-1212

@0xiamflux 0xiamflux self-assigned this Oct 14, 2025
@linear
Copy link
Copy Markdown

linear Bot commented Oct 14, 2025

@0xDiscotech 0xDiscotech added hold Do not merge for now and removed hold Do not merge for now labels Oct 14, 2025
@0xDiscotech 0xDiscotech merged commit 3a9fb15 into sc-feat/revshare-setup Oct 16, 2025
1 check passed
@0xDiscotech 0xDiscotech deleted the chore/initialize-vaults-over-constructor branch October 16, 2025 21:27
0xDiscotech added a commit that referenced this pull request Nov 18, 2025
…ethereum-optimism#1257)

* feat: add Revenue Share Upgrade Path (#8)

* feat: Deploy FeesDepositor (#15)

* feat: late opt-in template (#21)

* refactor: contracts update creationcode (#23)

* fix: sync (#24)

* test: add require tests for fields on Revenue Sharing templates (#26)

* fix: L2 target ProxyAdmin (#27)

* chore: update cost of upgrades and deployments (#29)

* test: revenue sharing upgrade unit tests (#22)

* test: add basic validation for fees depositor template (#32)

* chore: updates the bytecode for vaults, using initialize (#31)

* test: integration supersim revshare (#30)

* fix: broken simulations

* fix: wrong location of synced regression tests

* test: integration revshare late opt in (#33)

* fix: ir fixes (#38)

* chore: gas costs (#39)

* fix: minors (#46)

* fix: remove vm usage for getCreate2Address utils function (#48)

* feat: descope late opt in (#51)

* feat: add rev share upgrader (#53)

* fix: bash on comment

* fix: forge fmt

* refactor: reduce code size by splitting logic between lib and contract (#59)

* refactor: reduce code size by splitting logic between lib and contract

* chore: remove comment

* chore: remove prefix

* refactor: split library (#60)

* refactor: reduce code size by splitting logic between lib and contract

* chore: remove comment

* chore: remove prefix

* refactor: split library in two to avoid code size error

* feat: regression tests (#61)

* fix: relay typo

* fix: improve template validation checks (#62)

* fix: wrong fee splitter bytecode (#63)

* fix: skip comment

* fix: rename test create two deployer

* chore: add commit

* feat: add upgrader deployment script (#64)

* chore: update gas limits

* refactor: use create two to get a deterministic deployment of the upgrader (#68)

* chore: add todos (#66)

* chore: remove tenderly simulations (#65)

* chore: deploy and update new contract (#67)

* fix: forge fmt (#69)

* chore: fuzz init code on get create2 test (#70)

* feat: deploy revshare mainnet (#71)

* fix: forge fmt (#72)

* chore: add todo comments (#73)

* chore: reduce tenderly gas

Co-authored-by: Maurelian <john@oplabs.co>

* fix: reduce tenderly gas limit on sepolia (#77)

---------

Co-authored-by: IamFlux <175354924+0xiamflux@users.noreply.github.com>
Co-authored-by: Chiin <77933451+0xChin@users.noreply.github.com>
Co-authored-by: 0xchin <alanracciatti1220@gmail.com>
Co-authored-by: Maurelian <john@oplabs.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants